rewrite each: make sure to normalize/unfold each side #417
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the attached test case, where we try to rewrite every `bar` in the context into `baz`, but since `bar` is unfold, it will never appear as such, making the rewrite do nothing. This happens pretty often for operators like `SizeT.(+)`, which is just defined as `SizeT.add`, with an unfold qualifier. Without this patch, one cannot use these operators in the LHS of a rewrite and must use the underlying names.
|
BTW, do you think we should change fn foo (x: ref (ref int))
preserves exists* (y: ref int) z. (x |-> y) ** (y |-> z)
{
let z = ! !x;
rewrite each z as id z; // no-op now, but would work with this PR and that change
} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the attached test case, where we try to rewrite every
barin the context intobaz, but sincebaris unfold, it will never appear as such, making the rewrite do nothing.This happens pretty often for operators like
SizeT.(+), which is just defined asSizeT.add, with an unfold qualifier. Without this patch, one cannot use these operators in the LHS of a rewrite and must use the underlying names.