No batching of warning/errors #3810
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtzguido
changed the title
|
We'll leave 2 for the future. Check world running here: https://github.com/mtzguido/FStar/actions/runs/16179381999 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the error reporting module not batch nor deduplicate any errors, and just print them immediately instead. It improves response time in batch mode, since the warnings show up immediately as they are logged instead of after checking the whole module.
Marking WIP since
1- We should make sure to not raise so many errors for the same reason, which was the original reason why we deduplicate
2- We should make the IDE report immediately, it currently also batches.
This would make interactivity in Pulse much better by showing warnings over statements as soon as they are checked.