Fix sRGB backbuffers on the SDL_GPU and D3D11 backends #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kg
changed the title
| @@ -2699,6 +2706,10 @@ static void D3D11_INTERNAL_CreateSwapChain( | |||
| { | |||
| colorSpace = DXGI_COLOR_SPACE_RGB_FULL_G10_NONE_P709; | |||
| } | |||
| else if (sRGB) | |||
| { | |||
| colorSpace = DXGI_COLOR_SPACE_RGB_FULL_G22_NONE_P709; | |||
There was a problem hiding this comment.
Doesn't the else cover this?
There was a problem hiding this comment.
I'm not sure this or the other else are both the correct color space
There was a problem hiding this comment.
I did some more testing and it seems like they're right, but it feels like either the sRGB or non-sRGB arm should be G10 so I'm not sure what's going on.
Co-authored-by: Ethan Lee <[email protected]>
|
This isn't ready to merge yet, I just noticed that this color space code leaks a reference to the swapchain EDIT: Fixed EDIT 2: Sort of. I think we need to release swapchain3 instead of swapchain, because it's technically legal for queryinterface to return a separate object... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sRGB textures and render targets work but when you request a sRGB backbuffer, you don't get one right now.
On SDL_GPU we aren't flowing the sRGB flag through.
On D3D11, we changed to flip model which doesn't allow sRGB backbuffers, you have to set the colorspace on the swapchain instead.
This PR also fixes a swapchain leak triggered by enabling HDR in D3D11