-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extending provenance report history #155
Conversation
First thing I noticed: Using Sonias db, I'm looking at the prov reports for data products 2 and 3. This isn't related to the EDIT: Same for 4 and 5. EDIT2: Data product 7 also includes data product 6 in it's graph but shouldn't |
I'm trying to understand what is going on here, the list |
Could be where I'm going wrong |
Happy to look at it over zoom if you want. EDIT: Because I think I see the issue, but I'm not sure the best way of handling it. |
Codecov Report
@@ Coverage Diff @@
## main #155 +/- ##
==========================================
+ Coverage 53.96% 54.97% +1.01%
==========================================
Files 18 18
Lines 1047 1075 +28
==========================================
+ Hits 565 591 +26
- Misses 482 484 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
I think I have a fix... |
Sorry been in and out of meeting this afternoon, do you just want to go for it with the fix |
Hopefully this works for you. Please let me know if I need to look at it again. |
Kudos, SonarCloud Quality Gate passed!
|
The api/prov endpoint now accepts the parameter
depth
#152