Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extending provenance report history #155

Merged
merged 8 commits into from
Sep 30, 2021
Merged

Conversation

antony-wilson
Copy link
Collaborator

The api/prov endpoint now accepts the parameter depth

#152

@ghost
Copy link

ghost commented Sep 28, 2021

First thing I noticed:

Using Sonias db, I'm looking at the prov reports for data products 2 and 3. This isn't related to the depth flag, but both of those reports include the other data product as an entity even though they don't appear to be a part of each other's provenance tree - they just happen to have come from the same code run.

EDIT: Same for 4 and 5.

EDIT2: Data product 7 also includes data product 6 in it's graph but shouldn't

@ghost
Copy link

ghost commented Sep 28, 2021

I'm trying to understand what is going on here, the list input_files doesn't seem to contain what I expect it to.

@antony-wilson
Copy link
Collaborator Author

I'm trying to understand what is going on here, the list input_files doesn't seem to contain what I expect it to.

Could be where I'm going wrong

@ghost
Copy link

ghost commented Sep 28, 2021

I'm trying to understand what is going on here, the list input_files doesn't seem to contain what I expect it to.

Could be where I'm going wrong

Happy to look at it over zoom if you want.

EDIT: Because I think I see the issue, but I'm not sure the best way of handling it.

@codecov
Copy link

codecov bot commented Sep 28, 2021

Codecov Report

Merging #155 (347ec97) into main (9d4352e) will increase coverage by 1.01%.
The diff coverage is 94.73%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #155      +/-   ##
==========================================
+ Coverage   53.96%   54.97%   +1.01%     
==========================================
  Files          18       18              
  Lines        1047     1075      +28     
==========================================
+ Hits          565      591      +26     
- Misses        482      484       +2     
Flag Coverage Δ
unittests 54.97% <94.73%> (+1.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
data_management/rest/views.py 77.72% <66.66%> (-0.58%) ⬇️
data_management/prov.py 98.54% <100.00%> (+0.69%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d4352e...347ec97. Read the comment docs.

@ghost
Copy link

ghost commented Sep 28, 2021

I think I have a fix...

@antony-wilson
Copy link
Collaborator Author

Sorry been in and out of meeting this afternoon, do you just want to go for it with the fix

@ghost
Copy link

ghost commented Sep 28, 2021

Hopefully this works for you. Please let me know if I need to look at it again.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@antony-wilson antony-wilson marked this pull request as ready for review September 29, 2021 15:36
@antony-wilson antony-wilson requested a review from a user September 29, 2021 15:36
@antony-wilson antony-wilson merged commit ee14503 into main Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants