[SP] [105.13.5] fix: disable next-page button on the last page#11
Merged
Merged
Conversation
Prefer the authoritative pageCount returned by the backend over the "rowsPerPage > rowCountPage" heuristic, which failed when the last page was exactly full (e.g. 75 results / 15 per page) and let users click into an empty "Page 6 of 5". Falls back to the heuristic when pageCount is unavailable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task: https://app.clickup.com/t/869czvkrw
Summary
The next-page button stays enabled on a full last page (e.g. 75 results / 15 per page), so users can click past the end into an empty page. The faulty heuristic (
rowsPerPage > rowCountPage) predates #8, but #8 made it visible by adding the "Page X of Y" label. Users were seeing "Page 6 of 5" before the button disables.Now that the backend returns
pageCount, prefercurrentPage >= pageCountand fall back to the heuristic only whenpageCountis unavailable.Test plan