Skip to content

[SP] [105.13.5] fix: disable next-page button on the last page#11

Merged
Ramon-Jimenez merged 1 commit into
version-105.13.5-spfrom
fix/list-totals-last-page
May 11, 2026
Merged

[SP] [105.13.5] fix: disable next-page button on the last page#11
Ramon-Jimenez merged 1 commit into
version-105.13.5-spfrom
fix/list-totals-last-page

Conversation

@MatiasArriola
Copy link
Copy Markdown

@MatiasArriola MatiasArriola commented May 8, 2026

Task: https://app.clickup.com/t/869czvkrw

Summary

The next-page button stays enabled on a full last page (e.g. 75 results / 15 per page), so users can click past the end into an empty page. The faulty heuristic (rowsPerPage > rowCountPage) predates #8, but #8 made it visible by adding the "Page X of Y" label. Users were seeing "Page 6 of 5" before the button disables.

Now that the backend returns pageCount, prefer currentPage >= pageCount and fall back to the heuristic only when
pageCount is unavailable.

imagen

Test plan

  • Open a working list with a total that is an exact multiple of the page size (e.g. 75 / 15). On the last page, the next-page button is disabled.
  • Open a working list whose last page is partial (e.g. 73 / 15). Last page still disables next correctly.
  • Navigate forward/back across pages — counts and "Page X of Y" stay consistent.

Prefer the authoritative pageCount returned by the backend over the
"rowsPerPage > rowCountPage" heuristic, which failed when the last
page was exactly full (e.g. 75 results / 15 per page) and let users
click into an empty "Page 6 of 5". Falls back to the heuristic when
pageCount is unavailable.
@Ramon-Jimenez Ramon-Jimenez merged commit 9ea4536 into version-105.13.5-sp May 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants