Skip to content

Issue with rate limiting and ttl window #943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: release/5.0
Choose a base branch
from
Open

Issue with rate limiting and ttl window #943

wants to merge 3 commits into from

Conversation

underscope
Copy link
Collaborator

TTL was missing on the request limiter store (due to which state was not expiring over time).

@underscope
Updated request limiter
0727570 
- Fixed issue with store due to missing ttl
- Create new store for different ttl
@underscope underscope changed the title Issue with rate limiting and custom window Issue with rate limiting and custom ttl window Nov 25, 2021
@underscope underscope changed the title Issue with rate limiting and custom ttl window Issue with rate limiting and ttl window Nov 25, 2021
@bubafinder
Copy link

@underscope I noticed some issues when sending emails with SSL configured EMAIL_SSL=1. Emails are not received. Works as expected when EMAIL_SSL=0.
@kronicker gave his opinion maybe it is problem with the lib we are using.
Should I raise an issue?

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
👌 passed QA
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@underscope @bubafinder