Fix wifi flashing via flasher.pyz#221
Open
jurgelenas wants to merge 1 commit into
Open
Conversation
Restore call/signature alignment between binary_configurator and upload_via_esp8266_backpack, broken by the STM32 removal in 20d083c (#177): - binary_configurator.upload_wifi: drop the orphaned `False` (was isstm) so the 3-param do_upload signature matches. - upload_via_esp8266_backpack.do_upload: the `[isstm]` indexer was removed but the `['update', 'upload']` list literal was left in the URL format string, producing `http://elrs_txbp/['update', 'upload']`. Replace with `/update`. Also tighten the bare `except:` in upload_wifi so failures surface as stderr instead of being silently masked - this is what hid the TypeError across releases 1.5.2 - 1.5.5.
deadbytefpv
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restore call/signature alignment between binary_configurator and upload_via_esp8266_backpack, broken by the STM32 removal in 20d083c (#177):
False(was isstm) so the 3-param do_upload signature matches.[isstm]indexer was removed but the['update', 'upload']list literal was left in the URL format string, producinghttp://elrs_txbp/['update', 'upload']. Replace with/update.Also tighten the bare
except:in upload_wifi so failures surface as stderr instead of being silently masked.