[HOLD] Revert "[Home Page] Add Concierge prompt box to home For You section" - #99572
[HOLD] Revert "[Home Page] Add Concierge prompt box to home For You section"#99572puneetlath wants to merge 1 commit into
Conversation
🦜 Polyglot Parrot! 🦜Squawk! Looks like you added some shiny new English strings. Allow me to parrot them back to you in other tongues: View the translation diffdiff --git a/src/languages/es.ts b/src/languages/es.ts
index 1ed6d28a..5979d560 100644
--- a/src/languages/es.ts
+++ b/src/languages/es.ts
@@ -9,7 +9,6 @@
* - Improve the prompts in prompts/translation, or
* - Improve context annotations in src/languages/en.ts
*/
-
import CONST from '@src/CONST';
import type {OriginalMessageReportPreview, OriginalMessageSettlementAccountLocked, PersonalRulesModifiedFields, PolicyRulesModifiedFields} from '@src/types/onyx/OriginalMessage';
Note You can apply these changes to your branch by copying the patch to your clipboard, then running |
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
puneetlath
changed the title
|
Putting this on hold. We might not need to revert after all. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9ea07af681
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| const filtered = actions.filter(isCurrentSessionAction); | ||
| if (filtered.length === 0) { | ||
| // Side panel: nothing matched the current session yet (e.g. just after reopen, before the new | ||
| // message propagates). Show the greeting instead of `actions` to avoid flashing stale history. | ||
| if (!isConciergeMainDM && conciergeGreetingAction) { | ||
| const createdAction = actions.find(isCreatedAction); | ||
| return createdAction ? [conciergeGreetingAction, createdAction] : [conciergeGreetingAction]; | ||
| } | ||
| return actions; |
There was a problem hiding this comment.
When a contextual Concierge side panel is reopened with hidden prior history and the user sends a new message, there is a window before the optimistic/server action reaches this list where filtered is empty. Returning the original actions in that window exposes all pre-session messages, causing the stale-history flash that the removed branch specifically prevented; return the greeting/created actions for non-main-DM side panels instead.
Useful? React with 👍 / 👎.
| const adminPoliciesSelectorWrapper = useCallback((policies: OnyxCollection<Policy>) => activeAdminPoliciesSelector(policies, login ?? ''), [login]); | ||
| const [adminPolicies] = useOnyx(ONYXKEYS.COLLECTION.POLICY, { | ||
| selector: adminPoliciesSelectorWrapper, | ||
| }); |
There was a problem hiding this comment.
For workspace admins, activeAdminPoliciesSelector returns complete policy objects, so unrelated changes to large fields such as employee lists, connections, or custom units change the selected value and rerender the Home section. This also restores per-render connection scanning below, undoing the recently added createTimeSensitiveAdminPoliciesSelector optimization; the standalone section should continue selecting only the policy fields and derived broken connections it consumes.
Useful? React with 👍 / 👎.
|
Not going to revert after all. |
2 participants
Explanation of Change
Reverts Expensify/App#98336, removing the Concierge prompt box and its related Home page changes.
Fixed Issues
$
PROPOSAL:
Tests
Automated checks could not run because this checkout is missing
bun,jest, andstorybook.Offline tests
QA Steps
Same as tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionScreenshots/Videos
Android: Native
Not tested.
Android: mWeb Chrome
Not tested.
iOS: Native
Not tested.
iOS: mWeb Safari
Not tested.
MacOS: Chrome / Safari
Not tested.