perf: only subscribe to policies in IOURequestStepConfirmation while the participant picker is open by OlimpiaZurek · Pull Request #99544 · Expensify/App

OlimpiaZurek · 2026-08-26T09:41:29Z

Explanation of Change

IOURequestStepConfirmation subscribed to the whole policy collection on every mount, but only used it inside handleParticipantsAdded, to find the destination workspace's rate and category defaults when the user switches recipient. That subscription and the map over every policy sat on the confirmation's first render for something first render never touches, and the cost grows with the number of workspaces.

Now the participant picker passes that policy instead. ParticipantSearchResults already subscribes to policies and only mounts while the picker is open, so it resolves the selected workspace's policy and passes it as an optional second argument to onParticipantsAdded. The confirmation reads it there and no longer subscribes to policies at all.

The argument is optional, so the other onParticipantsAdded callers (the standalone participant step and the Share flow) are unchanged. The policy is only read, never attached to the participant, so nothing extra is written to the draft transaction.

Fixed Issues

$ #99671
PROPOSAL:

Tests

On an account with at least one workspace, open the FAB, tap Create expense, then Scan or Manual, and reach Confirm details. It renders normally with no flicker or reset.
Tap the recipient row, choose a different workspace, and confirm the recipient updates without error.
For a Track distance expense, switch to a different workspace and confirm the mileage rate and default category reset to that workspace's defaults; switch to a P2P recipient and confirm the rate and category reset accordingly.
Confirm the standalone participant step and the Share flow still select participants normally.

Verify that no errors appear in the JS console

Offline tests

QA Steps

Same as tests
// TODO: These must be filled out, or the issue title must include "[No QA]."

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

…the participant picker is open

OlimpiaZurek · 2026-08-26T09:41:43Z

@codex

codecov · 2026-08-26T09:45:15Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
...s/iou/request/MoneyRequestParticipantsSelector.tsx	`0.00% <ø> (ø)`
...es/iou/request/step/IOURequestStepConfirmation.tsx	`73.48% <100.00%> (-0.23%)`	⬇️
src/pages/iou/request/ParticipantSearchResults.tsx	`0.62% <0.00%> (-0.01%)`	⬇️
... and 34 files with indirect coverage changes

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 22917021bf

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

melvin-bot · 2026-08-26T12:21:47Z

@cretadn22 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

…kup component

cretadn22 · 2026-08-26T15:31:04Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2026-08-27.at.09.00.22.mov

Android: mWeb Chrome

Screen.Recording.2026-08-27.at.08.57.56.mov

iOS: HybridApp

Screen.Recording.2026-08-27.at.08.58.56.mov

iOS: mWeb Safari

Screen.Recording.2026-08-27.at.09.01.00.mov

MacOS: Chrome / Safari

Screen.Recording.2026-08-27.at.08.53.59.mov

cretadn22 · 2026-08-27T09:45:34Z

@OlimpiaZurek Just noticed that IOURequestStepConfirmation still seems to subscribe to the full policy collection through useParticipantsPolicies hook

cretadn22 · 2026-08-27T09:51:45Z

The policy parameter is missing from being passed in this spot

App/src/pages/iou/request/ParticipantSearchResults.tsx

Line 250 in 72d3672

onParticipantsAdded(sanitizedParticipants);

OlimpiaZurek · 2026-08-27T10:51:03Z

@OlimpiaZurek Just noticed that IOURequestStepConfirmation still seems to subscribe to the full policy collection through useParticipantsPolicies hook

This PR removes the useMappedPolicies subscription, which read the whole collection with no selector and was only used in the handler. useParticipantsPolicies is a different one: it uses a selector that returns only the participants' policies and feeds the participant row on first paint, so it's the narrowed form, not the whole-collection ma

OlimpiaZurek · 2026-08-27T10:53:30Z

The policy parameter is missing from being passed in this spot

App/src/pages/iou/request/ParticipantSearchResults.tsx

Line 250 in 72d3672

onParticipantsAdded(sanitizedParticipants);

The parameter isn't needed here because handleSelectionChange only runs for splits, and handleParticipantsAdded only reads selectedPolicy for non-split expenses. That's why it's optional rather than required.

…tion # Conflicts: # src/pages/iou/request/step/IOURequestStepConfirmation.tsx

cretadn22 · 2026-08-27T15:55:50Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 60df7c4e41

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-08-27T16:01:29Z

+        // Resolve the chosen workspace's policy and pass it up so the confirmation step can reset the rate and category
+        // without subscribing to every policy. allPolicies is already loaded on this screen, so this adds no new subscription.
+        const selectedPolicy = option.policyID ? allPolicies?.[`${ONYXKEYS.COLLECTION.POLICY}${option.policyID}`] : undefined;


Mount the policy subscriber only while the picker is visible

On web and Android, this does not actually limit the policy subscription to an open picker: ParticipantPicker/index.tsx intentionally keeps BaseParticipantPicker mounted when isVisible is false, so ParticipantSearchResults and its useOnyx(ONYXKEYS.COLLECTION.POLICY) subscription remain active for the confirmation page's entire lifetime. Consequently high-traffic accounts still load and react to the full policy collection on the confirmation screen; the picker content or its policy-dependent subtree needs to be gated by visibility while preserving the modal shell required for its exit animation.

Useful? React with 👍 / 👎.

The purpose of this change appears to be removing a redundant subscription in IOURequestStepConfirmation

github-actions · 2026-08-28T17:58:23Z

🚧 Julesssss has triggered a test Expensify/App build. You can view the workflow run here.

OSBotify · 2026-08-28T18:01:40Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-08-28T18:02:36Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #99544.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-df4c82b-d3ba73b-b346bb36a9bfdb6a3a06c0a9cd74969daa565d32/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-df4c82b-d3ba73b-ccea9f75e31640b54d30dc38c48430932c47f29e/index.html

Web 🕸️
https://99544.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-08-28T21:36:16Z

🚀 Deployed to staging by https://github.com/Julesssss in version: 9.4.64-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

MelvinBot · 2026-08-28T21:39:12Z

No help site changes are required for this PR, so I have not created a draft docs PR.

This is an internal performance refactor with no user-facing change. IOURequestStepConfirmation stopped subscribing to the whole policy collection; the selected workspace's policy is now passed up from ParticipantSearchResults through onParticipantsAdded. The resulting behavior is identical — switching the recipient to a different workspace still resets the mileage rate and default category exactly as before.

What I checked

All five changed files are component internals, prop types, or tests:

src/components/ParticipantPicker/types.ts — added optional selectedPolicy argument to the onParticipantsAdded type
src/pages/iou/request/MoneyRequestParticipantsSelector.tsx — same type change
src/pages/iou/request/ParticipantSearchResults.tsx — resolves the chosen workspace's policy from an already-loaded subscription and forwards it
src/pages/iou/request/step/IOURequestStepConfirmation.tsx — removed the useMappedPolicies subscription and reads the passed policy instead
tests/ui/components/IOURequestStepConfirmationPageTest.tsx — test coverage for the new argument

There are no new or renamed features, tabs, settings, buttons, or copy strings. The help site articles that cover this area — Distance Expenses and Set distance rates — describe the user-facing flow, which this PR does not alter. They remain accurate as written.

If you would still like a docs PR for something related that this change surfaced, reply with @MelvinBot and what you'd like documented, and I'll draft it.

view run

perf: only subscribe to policies in IOURequestStepConfirmation while …

2291702

…the participant picker is open

melvin-bot Bot assigned OlimpiaZurek Aug 26, 2026

chatgpt-codex-connector Bot reviewed Aug 26, 2026

View reviewed changes

Comment thread src/pages/iou/request/step/IOURequestStepConfirmation.tsx Outdated

fix tests

74b4675

OlimpiaZurek marked this pull request as ready for review August 26, 2026 12:21

OlimpiaZurek requested review from a team as code owners August 26, 2026 12:21

melvin-bot Bot requested review from cretadn22 and removed request for a team August 26, 2026 12:21

melvin-bot Bot requested review from garrettmknight and removed request for a team August 26, 2026 12:21

github-actions Bot reviewed Aug 26, 2026

View reviewed changes

Comment thread src/pages/iou/request/step/confirmation/ParticipantPolicyLookup.tsx Outdated

github-actions Bot reviewed Aug 26, 2026

View reviewed changes

Comment thread src/pages/iou/request/step/confirmation/ParticipantPolicyLookup.tsx Outdated

pass the selected policy through onParticipantsAdded instead of a loo…

4b2697e

…kup component

garrettmknight removed their request for review August 26, 2026 13:28

OlimpiaZurek mentioned this pull request Aug 26, 2026

[Metrics] ManualShutterToConfirmation - Optimize "Confirm details" page rendering after receipt capture #83503

Open

cristipaval mentioned this pull request Aug 27, 2026

[Metrics] ManualShutterToConfirmation - Stop subscribing to the whole policy collection in IOURequestStepConfirmation #99671

Open

Merge branch 'main' into perf/83503-confirmation-gate-policy-subscrip…

60df7c4

…tion # Conflicts: # src/pages/iou/request/step/IOURequestStepConfirmation.tsx

chatgpt-codex-connector Bot reviewed Aug 27, 2026

View reviewed changes

cretadn22 approved these changes Aug 27, 2026

View reviewed changes

melvin-bot Bot requested a review from cristipaval August 27, 2026 16:03

melvin-bot Bot requested a review from Julesssss August 27, 2026 16:03

cristipaval approved these changes Aug 27, 2026

View reviewed changes

Julesssss approved these changes Aug 28, 2026

View reviewed changes

Julesssss merged commit df4c82b into Expensify:main Aug 28, 2026
38 of 41 checks passed

OSBotify mentioned this pull request Aug 28, 2026

Deploy Checklist: New Expensify 2026-08-28 #99794

Open

41 tasks

Uh oh!

Conversation

OlimpiaZurek commented Aug 26, 2026 • edited by cristipaval Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

OlimpiaZurek commented Aug 26, 2026

Uh oh!

codecov Bot commented Aug 26, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

melvin-bot Bot commented Aug 26, 2026

Uh oh!

Uh oh!

Uh oh!

cretadn22 commented Aug 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

cretadn22 commented Aug 27, 2026

Uh oh!

cretadn22 commented Aug 27, 2026

Uh oh!

OlimpiaZurek commented Aug 27, 2026

Uh oh!

OlimpiaZurek commented Aug 27, 2026

Uh oh!

cretadn22 commented Aug 27, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Aug 27, 2026

Choose a reason for hiding this comment

Uh oh!

cretadn22 Aug 27, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented Aug 28, 2026

Uh oh!

OSBotify commented Aug 28, 2026

Uh oh!

github-actions Bot commented Aug 28, 2026

Uh oh!

OSBotify commented Aug 28, 2026

Uh oh!

MelvinBot commented Aug 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

OlimpiaZurek commented Aug 26, 2026 •

edited by cristipaval

Loading

codecov Bot commented Aug 26, 2026 •

edited by github-actions Bot

Loading

cretadn22 commented Aug 26, 2026 •

edited

Loading