Skip to content

[CP Staging] Fix iOS - Home - Concierge prompt box remains expanded after sending attachment - #99537

Merged
grgia merged 1 commit into
Expensify:mainfrom
software-mansion-labs:@GCyganek/concierge-prompt-box/fix-prompt-expanded-after-sending-attachment
Aug 26, 2026
Merged

[CP Staging] Fix iOS - Home - Concierge prompt box remains expanded after sending attachment#99537
grgia merged 1 commit into
Expensify:mainfrom
software-mansion-labs:@GCyganek/concierge-prompt-box/fix-prompt-expanded-after-sending-attachment

Conversation

@GCyganek

@GCyganek GCyganek commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Explanation of Change

On iOS native, clearing the Concierge prompt's controlled value didn't reset the native input, so the composer stayed expanded (multi-line height) after sending. ConciergePromptBox now holds an useAnimatedRef on the Composer and calls forceClearInput via scheduleOnUI in clearInput, matching the pattern already used in ComposerWithSuggestions.

Fixed Issues

$ #99522
PROPOSAL: N/A

Tests

  1. Launch Expensify app.
  2. Go to Home.
  3. Tap on Concierge prompt box.
  4. Create 4 empty lines.
  5. Tap + > Add attachment > Choose from gallery.
  6. Select a photo.
  7. Tap Send.
  8. Tap app back button.
  9. Verify Concierge prompt box is collapsed after sending attachment.
  • Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Same as tests

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Screen.Recording.2026-08-26.at.10.58.09.mov
Android: mWeb Chrome
iOS: Native
Screen.Recording.2026-08-26.at.10.55.43.mov
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2026-08-26.at.11.01.47.mov

@GCyganek

Copy link
Copy Markdown
Contributor Author

@codex please review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. More of your lovely PRs please.

Reviewed commit: cf1f597b6f

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@GCyganek
GCyganek marked this pull request as ready for review August 26, 2026 09:05
@GCyganek
GCyganek requested review from a team as code owners August 26, 2026 09:05
@melvin-bot
melvin-bot Bot requested review from ZhenjaHorbach and flaviadefaria and removed request for a team August 26, 2026 09:05
@melvin-bot

melvin-bot Bot commented Aug 26, 2026

Copy link
Copy Markdown

@ZhenjaHorbach Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot removed the request for review from a team August 26, 2026 09:05
@ZhenjaHorbach

ZhenjaHorbach commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
2026-08-26.11.52.20.mov
Android: mWeb Chrome
2026-08-26.11.52.20.mov
iOS: HybridApp
2026-08-26.11.49.04.mov
iOS: mWeb Safari
2026-08-26.11.50.39.mov
MacOS: Chrome / Safari
2026-08-26.11.46.42.mov

@melvin-bot
melvin-bot Bot requested a review from puneetlath August 26, 2026 09:54
@grgia grgia changed the title Fix iOS - Home - Concierge prompt box remains expanded after sending attachment [CP Staging] Fix iOS - Home - Concierge prompt box remains expanded after sending attachment Aug 26, 2026
@grgia
grgia merged commit dd4d85c into Expensify:main Aug 26, 2026
42 of 44 checks passed
@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify pushed a commit that referenced this pull request Aug 26, 2026
…rge-prompt-box/fix-prompt-expanded-after-sending-attachment

[CP Staging] Fix iOS - Home - Concierge prompt box remains expanded after sending attachment

(cherry picked from commit dd4d85c)

(cherry-picked to staging by grgia)
@OSBotify OSBotify added the CP Staging marks PRs that have been CP'd to staging label Aug 26, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🚧 grgia has triggered a test Expensify/App build. You can view the workflow run here.

@os-botify

os-botify Bot commented Aug 26, 2026

Copy link
Copy Markdown

🔁 Filed a Staging retest request for deploy blockers #99522 after this PR was cherry-picked to staging.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/grgia in version: 9.4.61-3 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor

🤖 No help site changes required.

This PR is a purely technical bug fix — on iOS native, clearing the Concierge prompt's controlled value didn't reset the native input, so the composer stayed expanded after sending an attachment. The fix uses an useAnimatedRef + forceClearInput to force the native input to clear, matching the existing ComposerWithSuggestions pattern.

It restores the expected/correct behavior of an existing UI element and introduces no new user-facing feature, workflow, setting, label, or terminology.

Why no docs update is needed
  • The only changed file is src/pages/home/ForYouSection/ConciergePromptBox.tsx — a native-input reset fix, not a behavior/feature change users would read about.
  • A search of App/docs/articles found no help-site article that documents the Concierge prompt box or its expand/collapse behavior, so there is nothing to update.
  • Help-site articles document features, workflows, billing, and how-tos — not internal composer state handling.

Since no changes are required, I did not create a draft help site PR.


view run

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/AndrewGable in version: 9.4.61-4 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/grgia in version: 9.4.62-1 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor

🤖 No help site changes required (re-confirmed).

I already reviewed this PR — it's a purely technical iOS-native bug fix (forcing the Concierge prompt's native input to clear so the composer collapses after sending an attachment). It touches only src/pages/home/ForYouSection/ConciergePromptBox.tsx, adds no user-facing feature/workflow/setting/terminology, and no article under App/docs/articles documents this behavior. No draft help site PR was created because none is needed.


view run

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/AndrewGable in version: 9.4.62-4 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CP Staging marks PRs that have been CP'd to staging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants