[CP Staging] Fix Concierge prompt box requiring two taps with keyboard open - #99529
Conversation
|
@ZhenjaHorbach Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
typescript check failing is unrelated |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 06f19b211b
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
On mobile web, we don't reopen the keyboard, unlike the input chat 2026-08-26.11.21.25.mov |
Reviewer Checklist
Screenshots/VideosAndroid: HybridApp2026-08-26.11.11.17.movAndroid: mWeb Chrome2026-08-26.11.11.17.moviOS: HybridApp2026-08-26.11.23.38.moviOS: mWeb Safari2026-08-26.11.23.38.movMacOS: Chrome / Safari |
grgia
changed the title
|
🚧 grgia has triggered a test Expensify/App build. You can view the workflow run here. |
hmm, for me the keyboard does not get reopened in chat Simulator.Screen.Recording.-.iPhone.17.-.2026-08-26.at.12.46.05.mov |
…ge-keyboard-persist-tabs [CP Staging] Fix Concierge prompt box requiring two taps with keyboard open (cherry picked from commit 831a49c) (cherry-picked to staging by grgia)
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Cherry-picked to staging by https://github.com/grgia in version: 9.4.61-1 🚀
|
|
🤖 I reviewed this PR against the help site content in Why: This PR adds
Help site articles document product features and workflows, not internal UI interaction fixes like this one, so there's nothing to update. I did not create a draft PR. |
|
🚀 Deployed to production by https://github.com/AndrewGable in version: 9.4.61-4 🚀
Bundle Size Analysis (Sentry): |
|
🚀 Cherry-picked to staging by https://github.com/grgia in version: 9.4.62-1 🚀
|
No help site changes requiredI reviewed the changes in this PR against the help site content under Why: This PR is a one-line interaction bug fix — it adds Because no changes are required, I did not create a draft docs PR. If you believe a specific article should be updated, let me know which one and I'll take another look. |
|
🚀 Deployed to production by https://github.com/AndrewGable in version: 9.4.62-4 🚀
Bundle Size Analysis (Sentry): |
5 participants
Explanation of Change
The prompt box's buttons sit inside HomePage's ScrollView, which doesn't set keyboardShouldPersistTaps, so while the keyboard is open the first tap only dismisses the keyboard and never reaches the button
Fixed Issues
$ #99494
$ #99479
PROPOSAL: N/A
Tests
Offline tests
N/A
QA Steps
Same as tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Nagranie.z.ekranu.2026-08-26.o.10.26.08.mov
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari