Skip to content

[Search Router] Surface Book Travel in Create suggestions - #99516

Open
nabi-ebrahimi wants to merge 5 commits into
Expensify:mainfrom
nabi-ebrahimi:92752-search-router-travel-booking-action
Open

[Search Router] Surface Book Travel in Create suggestions#99516
nabi-ebrahimi wants to merge 5 commits into
Expensify:mainfrom
nabi-ebrahimi:92752-search-router-travel-booking-action

Conversation

@nabi-ebrahimi

@nabi-ebrahimi nabi-ebrahimi commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Explanation of Change

Adds Book travel to the Search Router’s existing Create suggestions.

The action follows the same eligibility and navigation rules as the existing FAB travel item:

  • Uses only the active workspace.
  • Appears only when Travel is enabled for that workspace.
  • Opens TravelDot when the account and workspace are ready.
  • Otherwise opens the existing Travel/My Trips flow.
  • Uses the localized Book travel label and Suitcase icon.
  • Replaces an existing RHP instead of stacking another modal.
  • Keeps anonymous-user interception.
  • Leaves Quick Action excluded.

This reuses the existing Travel eligibility utilities and does not introduce new routes, translations, ranking rules, or navigation item types.

Fixed Issues

$ #92752
PROPOSAL: #92752 (comment)

Book Travel search matching

  1. Sign in with an active workspace that has Travel enabled.
  2. Open Search Router.
  3. Search for book travel.
  4. Repeat with BOOK TRAVEL, go to book travel, and go to book travel.
  5. Verify the Book travel action appears for every query.
  6. Verify the label does not have a Go to prefix.
  7. Verify the Suitcase icon is displayed.

Active workspace eligibility

  1. Have two workspaces, with Travel enabled in only one.
  2. Make the workspace without Travel active.
  3. Search for book travel.
  4. Verify Book travel is not shown.
  5. Make the Travel-enabled workspace active.
  6. Repeat the search.
  7. Verify Book travel is shown.

RHP replacement

  1. Open an existing RHP.
  2. Open Search Router and select Book travel.
  3. Verify the existing RHP closes before the Travel flow opens.
  4. Verify the RHPs do not stack.
  • Verify that no errors appear in the JS console

Offline tests

  1. Load a Travel-enabled workspace while online.
  2. Enable forced offline mode.
  3. Open Search Router and search for book travel.
  4. Verify the result uses the cached active workspace eligibility.
  5. Select the result.
  6. Verify it follows the existing offline Travel behavior without crashing or stacking RHPs.

QA Steps

Same as the Tests and Offline tests above.

// TODO: These must be filled out, or the issue title must include "[No QA]."

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Screen.Recording.2026-08-26.at.2.29.14.PM.mov
Screen.Recording.2026-08-26.at.2.31.26.PM.mov
Android: mWeb Chrome
Screen_Recording_20260826_135540_Chrome.mp4
Screen_Recording_20260826_135717_Chrome.mp4
iOS: Native
Screen.Recording.2026-08-26.at.3.27.44.PM.mov
Screen.Recording.2026-08-26.at.3.29.25.PM.mov
iOS: mWeb Safari
Screen.Recording.2026-08-26.at.3.32.43.PM.mov
Screen.Recording.2026-08-26.at.3.34.08.PM.mov
MacOS: Chrome / Safari
Screen.Recording.2026-08-26.at.11.54.07.AM.mov
Screen.Recording.2026-08-26.at.12.03.59.PM.mov
Screen.Recording.2026-08-26.at.11.59.45.AM.mov

@nabi-ebrahimi
nabi-ebrahimi marked this pull request as ready for review August 26, 2026 07:27
@nabi-ebrahimi
nabi-ebrahimi requested review from a team as code owners August 26, 2026 07:27
@melvin-bot
melvin-bot Bot requested review from flaviadefaria and marufsharifi and removed request for a team August 26, 2026 07:27
@melvin-bot

melvin-bot Bot commented Aug 26, 2026

Copy link
Copy Markdown

@marufsharifi Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@marufsharifi

Copy link
Copy Markdown
Contributor

@nabi-ebrahimi, could you please check the above ai feedback. thanks.

@nabi-ebrahimi

Copy link
Copy Markdown
Contributor Author

@nabi-ebrahimi, could you please check the above ai feedback. thanks.

Done, thanks!

@marufsharifi marufsharifi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just tow minor suggestions.

Comment thread src/components/Search/SearchRouter/useCreateNavigationSuggestions.ts Outdated
Comment thread tests/unit/useCreateNavigationSuggestionsTest.ts Outdated
@nabi-ebrahimi

Copy link
Copy Markdown
Contributor Author

@marufsharifi I addressed all the comments can you please review again, Thanks.

Comment thread tests/unit/useCreateNavigationSuggestionsTest.ts
Comment thread tests/unit/useCreateNavigationSuggestionsTest.ts
@nabi-ebrahimi

Copy link
Copy Markdown
Contributor Author

@marufsharifi thanks for the detailed review. All applicable comments have been addressed, and I added the missing focused coverage. The remaining non-blocking suggestions were clarified with the current scope and existing Travel behavior in mind. Could you please take another look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants