[Search Router] Surface Book Travel in Create suggestions - #99516
[Search Router] Surface Book Travel in Create suggestions#99516nabi-ebrahimi wants to merge 5 commits into
Conversation
|
@marufsharifi Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@nabi-ebrahimi, could you please check the above ai feedback. thanks. |
Done, thanks! |
marufsharifi
left a comment
There was a problem hiding this comment.
Looks good, just tow minor suggestions.
|
@marufsharifi I addressed all the comments can you please review again, Thanks. |
|
@marufsharifi thanks for the detailed review. All applicable comments have been addressed, and I added the missing focused coverage. The remaining non-blocking suggestions were clarified with the current scope and existing Travel behavior in mind. Could you please take another look? |
Explanation of Change
Adds
Book travelto the Search Router’s existing Create suggestions.The action follows the same eligibility and navigation rules as the existing FAB travel item:
Book travellabel and Suitcase icon.This reuses the existing Travel eligibility utilities and does not introduce new routes, translations, ranking rules, or navigation item types.
Fixed Issues
$ #92752
PROPOSAL: #92752 (comment)
Book Travel search matching
book travel.BOOK TRAVEL,go to book travel, andgo to book travel.Book travelaction appears for every query.Go toprefix.Active workspace eligibility
book travel.Book travelis not shown.Book travelis shown.RHP replacement
Book travel.Offline tests
book travel.QA Steps
Same as the Tests and Offline tests above.
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2026-08-26.at.2.29.14.PM.mov
Screen.Recording.2026-08-26.at.2.31.26.PM.mov
Android: mWeb Chrome
Screen_Recording_20260826_135540_Chrome.mp4
Screen_Recording_20260826_135717_Chrome.mp4
iOS: Native
Screen.Recording.2026-08-26.at.3.27.44.PM.mov
Screen.Recording.2026-08-26.at.3.29.25.PM.mov
iOS: mWeb Safari
Screen.Recording.2026-08-26.at.3.32.43.PM.mov
Screen.Recording.2026-08-26.at.3.34.08.PM.mov
MacOS: Chrome / Safari
Screen.Recording.2026-08-26.at.11.54.07.AM.mov
Screen.Recording.2026-08-26.at.12.03.59.PM.mov
Screen.Recording.2026-08-26.at.11.59.45.AM.mov