Skip to content

fix: prevent search error when using group-by reports - #99503

Open
nabi-ebrahimi wants to merge 4 commits into
Expensify:mainfrom
nabi-ebrahimi:fix/search-group-by-reports-error
Open

fix: prevent search error when using group-by reports#99503
nabi-ebrahimi wants to merge 4 commits into
Expensify:mainfrom
nabi-ebrahimi:fix/search-group-by-reports-error

Conversation

@nabi-ebrahimi

@nabi-ebrahimi nabi-ebrahimi commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Explanation of Change

This fixes an error that occurs when syntax-shaped text such as group-by: reports is entered in the Search results keyword input.

The search input now keeps syntax-shaped text as keyword text instead of allowing it to be parsed as an invalid groupBy value. It also prevents invalid groupBy values from reaching the search display logic.

As a result:

Entering group-by: reports no longer causes an error.
group-by: reports is treated as keyword text instead of a valid Group by filter.
The existing From filter remains applied.
Opening the Save Search page no longer fails because of the invalid groupBy value.

Fixed Issues

$ #89168
PROPOSAL: #89168 (comment)

Tests

Tests

Precondition:
Log in with an account that has some expenses.

  1. Go to Spend > Expenses.
  2. Open Advanced filters.
  3. Select From.
  4. Select the account you are currently logged in with.
  5. Apply the filter.
  6. Save the search.
  7. Click View results.
  8. In the Search bar, enter group-by: reports.
  9. Submit the search.
  10. Verify no error occurs.
  11. Verify the existing From filter remains applied.
  • Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Same as Tests.

// TODO: These must be filled out, or the issue title must include "[No QA]."

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Screen.Recording.2026-08-26.at.4.24.38.PM.mov
Android: mWeb Chrome
Screen_Recording_20260826_162226_Chrome.mp4
iOS: Native
Screen.Recording.2026-08-26.at.4.32.10.PM.mov
iOS: mWeb Safari
Screen.Recording.2026-08-26.at.4.34.19.PM.mov
MacOS: Chrome / Safari
Screen.Recording.2026-08-26.at.4.11.23.PM.mov

@nabi-ebrahimi
nabi-ebrahimi marked this pull request as ready for review August 26, 2026 12:13
@nabi-ebrahimi
nabi-ebrahimi requested review from a team as code owners August 26, 2026 12:13
@melvin-bot
melvin-bot Bot requested review from JmillsExpensify and truph01 and removed request for a team August 26, 2026 12:13
@melvin-bot

melvin-bot Bot commented Aug 26, 2026

Copy link
Copy Markdown

@truph01 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot removed the request for review from a team August 26, 2026 12:13

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a0f948eddd

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread src/libs/SearchQueryUtils.ts Outdated
Comment thread src/libs/SearchQueryUtils.ts Outdated
@codecov

codecov Bot commented Aug 26, 2026

Copy link
Copy Markdown

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
src/libs/SearchQueryUtils.ts 87.66% <100.00%> (+0.05%) ⬆️
src/pages/Search/SearchSavePage.tsx 0.00% <0.00%> (ø)
...components/Search/FilterDropdowns/DisplayPopup.tsx 0.00% <0.00%> (ø)
... and 65 files with indirect coverage changes

@JmillsExpensify JmillsExpensify left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nabi-ebrahimi

Copy link
Copy Markdown
Contributor Author

@truph01, Could you please review the PR , Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants