fix: prevent search error when using group-by reports - #99503
Open
nabi-ebrahimi wants to merge 4 commits into
Open
fix: prevent search error when using group-by reports#99503nabi-ebrahimi wants to merge 4 commits into
nabi-ebrahimi wants to merge 4 commits into
Conversation
nabi-ebrahimi
marked this pull request as ready for review
August 26, 2026 12:13
melvin-bot
Bot
requested review from
JmillsExpensify and
truph01
and removed request for
a team
August 26, 2026 12:13
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a0f948eddd
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
Contributor
Author
|
@truph01, Could you please review the PR , Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
This fixes an error that occurs when syntax-shaped text such as group-by: reports is entered in the Search results keyword input.
The search input now keeps syntax-shaped text as keyword text instead of allowing it to be parsed as an invalid groupBy value. It also prevents invalid groupBy values from reaching the search display logic.
As a result:
Entering group-by: reports no longer causes an error.
group-by: reports is treated as keyword text instead of a valid Group by filter.
The existing From filter remains applied.
Opening the Save Search page no longer fails because of the invalid groupBy value.
Fixed Issues
$ #89168
PROPOSAL: #89168 (comment)
Tests
Tests
Precondition:
Log in with an account that has some expenses.
Offline tests
N/A
QA Steps
Same as Tests.
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2026-08-26.at.4.24.38.PM.mov
Android: mWeb Chrome
Screen_Recording_20260826_162226_Chrome.mp4
iOS: Native
Screen.Recording.2026-08-26.at.4.32.10.PM.mov
iOS: mWeb Safari
Screen.Recording.2026-08-26.at.4.34.19.PM.mov
MacOS: Chrome / Safari
Screen.Recording.2026-08-26.at.4.11.23.PM.mov