Skip to content

[No QA] Update Merge-Accounts.md - #99484

Open
brianlee-expensify wants to merge 1 commit into
mainfrom
brianlee-expensify-patch-3
Open

[No QA] Update Merge-Accounts.md#99484
brianlee-expensify wants to merge 1 commit into
mainfrom
brianlee-expensify-patch-3

Conversation

@brianlee-expensify

Copy link
Copy Markdown
Contributor

Explanation of Change

added FAQ about Copilots with full access being able to merge accounts

Fixed Issues

https://github.com/Expensify/Expensify/issues/671341#issuecomment-5375220387

Tests

  • Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

added FAQ about Copilots with full access being able to merge accounts
## Can a Copilot merge accounts on my behalf?

Yes, a Copilot with Full Access can merge accounts while acting on your behalf.
- When they do, Expensify sends the security code to you (the account owner), not the Copilot. You'll need to share that code with your Copilot so they can complete the merge.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Readability / list formatting: The bulleted list on the following lines has no blank line separating it from this lead-in sentence. Some Markdown renderers require a blank line before a list, otherwise the bullets may render inline. Add a blank line after this sentence for reliable rendering and better scannability.

@github-actions

Copy link
Copy Markdown
Contributor

test body from stdin

@github-actions

Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This PR adds a single FAQ entry to Merge-Accounts.md explaining that a Copilot with Full Access can merge accounts on the account owner's behalf, and clarifying that the security code is sent to the owner rather than the Copilot. The change is small, well-scoped, and reinforces the article's primary workflow. This assessment is based solely on the added lines.

Scores Summary

  • Readability: 9/10 - Clear, concise, and scannable. A one-line direct answer followed by two supporting bullets is easy to follow.
  • AI Readiness: 8/10 - The new sub-heading is a proper natural-language question placed correctly under the FAQ section (exempt from task-based verb rules), uses the full feature name "Copilot", and matches real search intent. It stays as an ## under the existing # FAQ with no new top-level or deeper headings.
  • Style Compliance: 8/10 - "Full Access" matches the exact UI permission label (per Manage-Copilot-Access.md), and "Copilot" matches the dominant product terminology across the docs. One inconsistency: this article's existing data-transfer list still says "Co-pilots", so the file now mixes "Copilot" and "Co-pilots". The new text ("Copilot") is the correct form.

Key Findings

  • Positive: FAQ question format is compliant, the feature name is used in full, and the answer is direct and benefit-oriented ("keeps you in control").
  • Positive: Content stays within the single merge-accounts workflow and does not expand scope or add navigation/cross-linking clutter.
  • Minor: Terminology inconsistency within the file - "Copilot" (new) vs. "Co-pilots" (existing bullet). The new spelling is correct; consider aligning the older bullet in a follow-up.
  • No UI button or tab navigation is referenced in the added text, so bolding rules are largely N/A here.

Recommendations

  • No blocking issues. Safe to merge from a governance standpoint.
  • Optional: Align the existing "Co-pilots" bullet to "Copilots" for consistency with the new content and the rest of the help site.

Files Reviewed

  • docs/articles/new-expensify/settings/Merge-Accounts.md - Approved with minor terminology suggestion (added FAQ entry only).

Note: Detailed line-by-line feedback has been provided as inline comments.

@github-actions github-actions Bot changed the title Update Merge-Accounts.md [No QA] Update Merge-Accounts.md Aug 25, 2026
@OSBotify

Copy link
Copy Markdown
Contributor

A preview of your ExpensifyHelp changes have been deployed to https://40f11275.helpdot.pages.dev ⚡️

Updated articles:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants