-
Notifications
You must be signed in to change notification settings - Fork 3.9k
[WIP] feat: Integrate ExportDownloadStatusModal into report-level CSV export flow #93796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
truph01
wants to merge
4
commits into
Expensify:main
Choose a base branch
from
truph01:feat/93777
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,53 @@ | ||
| import React, {useState} from 'react'; | ||
| import ExportDownloadStatusModal from '@components/ExportDownloadStatusModal'; | ||
| import {clearExportDownload} from '@libs/actions/Export'; | ||
| import CONST from '@src/CONST'; | ||
| import ONYXKEYS from '@src/ONYXKEYS'; | ||
| import useLocalize from './useLocalize'; | ||
| import useOnyx from './useOnyx'; | ||
|
|
||
| type UseExportDownloadStatusModalReturn = { | ||
| /** Start tracking a queued export so the status modal renders for it */ | ||
| trackExport: (exportID: string) => void; | ||
|
|
||
| /** The realtime export status modal for the in-progress export (or null when none is active). Render it directly in the consumer. */ | ||
| exportDownloadStatusModal: React.JSX.Element | null; | ||
| }; | ||
|
|
||
| /** | ||
| * Encapsulates the shared wiring for the queued CSV export status modal (ExportDownloadStatusModal): it tracks the | ||
| * active export, renders the modal, and handles close/cleanup (no-op while still preparing, unless handed off to | ||
| * Concierge). Used by every surface that triggers a tracked template export so the modal wiring lives in one place. | ||
| * | ||
| * @param onCleanup - Optional extra cleanup to run once the modal is dismissed (e.g. clearing the selection). | ||
| */ | ||
| function useExportDownloadStatusModal(onCleanup?: () => void): UseExportDownloadStatusModalReturn { | ||
| const {translate} = useLocalize(); | ||
| const [activeExportID, setActiveExportID] = useState<string | undefined>(undefined); | ||
| const [activeExportDownload] = useOnyx(`${ONYXKEYS.COLLECTION.EXPORT_DOWNLOAD}${activeExportID}`); | ||
|
|
||
| const handleExportModalClose = () => { | ||
| // Keep the modal open while the export is still preparing (unless it was handed off to Concierge). | ||
| if (activeExportDownload?.state === CONST.EXPORT_DOWNLOAD.STATE.PREPARING && !activeExportDownload?.shouldSendFromConcierge) { | ||
| return; | ||
| } | ||
| if (activeExportID) { | ||
| clearExportDownload(activeExportID, activeExportDownload); | ||
| } | ||
| setActiveExportID(undefined); | ||
| onCleanup?.(); | ||
| }; | ||
|
|
||
| const exportDownloadStatusModal = activeExportID ? ( | ||
| <ExportDownloadStatusModal | ||
| exportID={activeExportID} | ||
| isVisible | ||
| onClose={handleExportModalClose} | ||
| failedBody={translate('exportDownload.csvFailedBody')} | ||
| /> | ||
| ) : null; | ||
|
|
||
| return {trackExport: setActiveExportID, exportDownloadStatusModal}; | ||
| } | ||
|
|
||
| export default useExportDownloadStatusModal; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When the ready/failed modal is closed with its Close button,
ExportDownloadStatusModal.handleClosealready callsclearExportDownload(exportID, ...)before invoking thisonCloseprop. This handler then callsclearExportDownloadagain, so every newly wired report/selection export close sends twoClearExportDownloadwrites; keep the parent handler limited to hiding the modal/selection cleanup or otherwise make only one layer own the API clear.Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolved