Update the domain groups table to the new style#93756
Conversation
luacmartins
changed the title
melvin-bot
Bot
requested review from
Krishna2323,
heyjennahay and
situchan
and removed request for
a team
|
@Krishna2323 @situchan One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 43b93bc32a
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Restore hasDomainGroupDetailsErrors-based RBR on group rows so rename, default, and preferred-workspace failures are visible on the Groups list.
|
Can we test build? |
| pendingAction: item.pendingAction, | ||
| onClose: item.dismissError, | ||
| }} | ||
| onPress={item.action} |
There was a problem hiding this comment.
sentryLabel is missing. Otherwise, this PR is straightforward and clean.
3 participants
Explanation of Change
Migrate the domain groups page to the shared
Tablecomponent.Fixed Issues
$ #86215
Tests
Offline tests
N/A
QA Steps
Same as tests