Update the domain admins table to the new style#93749
Conversation
Introduce a dedicated table for domain admins with sorting, search, and row rendering that matches the updated table patterns used elsewhere in the app.
Replace the legacy SelectionList-based layout with the new table component while preserving admin actions, primary contact badges, and navigation to admin details.
luacmartins
changed the title
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
melvin-bot
Bot
requested review from
Krishna2323,
joekaufmanexpensify and
situchan
and removed request for
a team
|
@Krishna2323 @situchan One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
I can take this one. Will review it later today. |
luacmartins
requested review from
Krishna2323
and removed request for
Krishna2323 and
situchan
|
Looks good, let's make sure we follow up with the search input/filter changes for this one too cc @JS00001 |
| style={[styles.textLabelSupporting, styles.lh16, styles.pre]} | ||
| numberOfLines={1} | ||
| > | ||
| {item.login} |
There was a problem hiding this comment.
Main used formatPhoneNumber(login) as alternateText. We should use use item.email here, the page already sets that on item.email.
| offlineWithFeedback={{ | ||
| errors: item.errors, | ||
| pendingAction: item.pendingAction, | ||
| dismissError: item.dismissError, |
There was a problem hiding this comment.
Error rows don't have the dismiss (X) button because TableRow is passing onDismiss={offlineWithFeedback.onClose} instead of dismissError.
Could we update it to use onClose: item.dismissError (same pattern as WorkspaceTableRow and WorkspaceCompanyCardsTableRow)? I noticed the same issue in WorkspaceCategoriesTableRow and WorkspaceDistanceRatesTableRow as well.
Could you fix those here? 😅
| ]; | ||
|
|
||
| return ( | ||
| <Table.Row |
4 participants
Explanation of Change
Migrate the domain admins page to the shared
Tablecomponent.Fixed Issues
$ #86217
Tests
Offline tests
N/A
QA Steps
Same as tests