v3.6.1 #10
Open
v3.6.1 #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Mark Vayngrib <[email protected]>
Co-authored-by: Mark Vayngrib <[email protected]>
* feat: support video splashscreen on iOS * feat: support video splashscreen on Android * fix: responsiveness * docs: update readme with new api * refactor: minor cleanup * refactor: include video_view in this module Co-authored-by: Alexander Pataridze <[email protected]>
* feat: allow pausing video * feat: add option to remove pause callback & resume video * feat: add option to pause video * feat: add option to remove pause callback & resume video * fix: android hideVideo * refactor: minor cleanup Co-authored-by: Alexander Pataridze <[email protected]>
andrejborstnik
left a comment
andrejborstnik
left a comment
There was a problem hiding this comment.
@arienemaiara let's open a PR with your changes to master & merge that. Also cherry-pick to 3.X branch.
Let's also make looping an optional feature in the api
Comment on lines
+77
to
+79
| + (void) restartVideoFromBeginning:(AVPlayerItem*)playerItem { | ||
| [lastPlayer seekToTime:kCMTimeZero]; | ||
| } |
There was a problem hiding this comment.
Need to check if lastPlayer !== nil first
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.