Skip to content

fix: get provider from window.exodus.ethereum #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: exodus
Choose a base branch
from

Conversation

bulgakovk
Copy link
Collaborator

Fixes the exodus ethereum provider path in Window object so the sync injection actually fixes the race condition.

Tested:

  1. Apply the patch:
Subject: [PATCH] fix: get provider from `window.exodus.ethereum`
---
Index: examples/with-next/pages/_app.tsx
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/examples/with-next/pages/_app.tsx b/examples/with-next/pages/_app.tsx
--- a/examples/with-next/pages/_app.tsx	(revision 8186995b15af3912083900cf5abffff044adfae4)
+++ b/examples/with-next/pages/_app.tsx	(date 1681993434230)
@@ -10,6 +10,7 @@
   argentWallet,
   trustWallet,
   ledgerWallet,
+  exodusWallet,
 } from '@rainbow-me/rainbowkit/wallets';
 import { configureChains, createClient, WagmiConfig } from 'wagmi';
 import { mainnet, polygon, optimism, arbitrum, goerli } from 'wagmi/chains';
@@ -43,6 +44,7 @@
       argentWallet({ chains }),
       trustWallet({ chains }),
       ledgerWallet({ chains }),
+      exodusWallet({ chains }),
     ],
   },
 ]);
  1. Run yarn dev in ./examples/with-next
  2. Make sure you can connect with Exodus:

image

@bulgakovk bulgakovk requested review from olistic and kewde April 20, 2023 12:32
@bulgakovk bulgakovk self-assigned this Apr 20, 2023
Copy link

@kewde kewde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

note: let's maybe wait for the new release to hit the webstore before trying to upstream this.

@bulgakovk
Copy link
Collaborator Author

Sounds good! The upstream PR (from exodus branch) is closed though so we can safely merge this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants