Skip to content
This repository was archived by the owner on Jul 8, 2025. It is now read-only.

Conversation

@MS-crew
Copy link

@MS-crew MS-crew commented May 24, 2025

Description

Describe the changes
Fix critical error

What is the current behavior? (You can also link to an open issue here)
When die as a custom role which is like role = none it kicks the player out of the server without giving any error, even when player log back in, get a black screen and nothing loads. Causes client error!

What is the new behavior? (if this is a feature change)
Fixed

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No

Other information:
https://discord.com/channels/656673194693885975/1375431933844262952/1375431933844262952

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentations

Submission checklist

  • I have checked the project can be compiled
  • I have tested my changes and it worked as expected

Patches (if there are any changes related to Harmony patches)

  • I have checked no IL patching errors in the console

Other

  • Still requires more testing

louis1706
louis1706 previously approved these changes May 27, 2025
@MS-crew MS-crew requested a review from louis1706 May 27, 2025 18:19
@github-actions github-actions bot added the Events This doesn't seem right label May 27, 2025
@MS-crew MS-crew changed the title fix: Critical CustomRole api Error fix: Critical CustomRole api Error & Invalid ragdoll error May 27, 2025
@MS-crew MS-crew closed this Jun 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

CustomModules Events This doesn't seem right

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants