Skip to content

fix: AdminToy.Position & Rotation ignoring parenting #687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Banalny-Banan wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

fix: AdminToy.Position & Rotation ignoring parenting #687

Banalny-Banan wants to merge 1 commit into from

Conversation

@Banalny-Banan
Copy link

@Banalny-Banan Banalny-Banan commented Nov 22, 2025 •
edited
Loading

Description

Describe the changes
NetworkPosition and NetworkRotation syncvars control local position/rotation, but Exiled AdminToy's properties were assigning global values to them.


Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentations

Submission checklist

  • I have checked the project can be compiled
  • I have tested my changes and it worked as expected

Patches (if there are any changes related to Harmony patches)

  • I have checked no IL patching errors in the console

Other

  • Still requires more testing

@github-actions github-actions bot added the API label Nov 22, 2025
louis1706
louis1706 approved these changes Dec 17, 2025
View reviewed changes
Copy link

@louis1706 louis1706 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i would approve it but i want Nameless to thinks if that could cause any breaking plugin ?

obvEve
obvEve approved these changes Dec 24, 2025
View reviewed changes
Copy link
Member

@obvEve obvEve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any plugin that depends on this not being the case, would have their intended behavior break - other than that LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@louis1706 louis1706 louis1706 approved these changes

@obvEve obvEve obvEve approved these changes

Assignees

@Banalny-Banan Banalny-Banan

Labels

API breaking-changes Do not merge Don't merge this PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Banalny-Banan @louis1706 @obvEve