Skip to content

Conversation

@MikeSus1
Copy link

@MikeSus1 MikeSus1 commented Apr 29, 2025

Description

Describe the changes
Make the user able to chose between stable and pre-release using the installer

What is the current behavior? (You can also link to an open issue here)
No choice and force the stable to be installed

What is the new behavior? (if this is a feature change)

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No

Other information:


Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentations

Submission checklist

  • I have checked the project can be compiled
  • I have tested my changes and it worked as expected

Patches (if there are any changes related to Harmony patches)

  • I have checked no IL patching errors in the console

Other

  • Still requires more testing

@MikeSus1
Copy link
Author

Capture d’écran 2025-04-29 141558
We could even make a version select option with numpad 3 for specific versions and will not require manual install.

Testing is rly needed on this as i cant test it locally because it takes the installer from github release
@VALERA771 VALERA771 requested a review from louis1706 August 15, 2025 09:42
Copy link

@louis1706 louis1706 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea about how that work

@MikeSus1
Copy link
Author

@louis1706 it just make the installer take one more argument wether or not you want to install a prerelease from the installer, however I Will not assure stability on it or anything as I kinda left discord / developement in general.

@louis1706
Copy link

@louis1706 it just make the installer take one more argument wether or not you want to install a prerelease from the installer, however I Will not assure stability on it or anything as I kinda left discord / developement in general.

I will let valera merging it

@VALERA771 VALERA771 self-requested a review September 6, 2025 21:27
@VALERA771 VALERA771 changed the base branch from LabAPI to dev September 7, 2025 12:31
@VALERA771 VALERA771 changed the base branch from dev to LabAPI September 7, 2025 12:32
@VALERA771
Copy link

#638 will be merged instead of this PR due to big outdate

@VALERA771 VALERA771 closed this Sep 7, 2025
VALERA771 added a commit that referenced this pull request Sep 7, 2025
Originally by MikeSus1 ([#520](#520))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants