-
Notifications
You must be signed in to change notification settings - Fork 48
Prom metrics #49
base: master
Are you sure you want to change the base?
Prom metrics #49
Conversation
@ameier38 would appreciate a review, whenever you have some spare time |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for PR. This would be a great addition. Could you also add the new options to the README?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, just one more request. Would prefer to keep the image values consistent throughout the chart. See comments.
Hi @ameier38, I'd like to ping on this PR as it's been some time since your last review. I'm asking because our team is currently running Eventstore on kubernetes and would appreciate it, if monitoring was part of the package. |
PR Checklist
What this PR does / why we need it:
It is common for k8s services to export metrics in the prometheus format. This PR enables EventStore to do that by adding this prometheus exporter as a sidecar in the
StatefulSet