Skip to content
This repository has been archived by the owner on Mar 6, 2020. It is now read-only.

Prom metrics #49

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

01100010011001010110010101110000

PR Checklist

  • Chart Version bumped
  • CHANGELOG.md updated
  • Variables and other changes are documented in the README.md

What this PR does / why we need it:
It is common for k8s services to export metrics in the prometheus format. This PR enables EventStore to do that by adding this prometheus exporter as a sidecar in the StatefulSet

@01100010011001010110010101110000
Copy link
Author

@ameier38 would appreciate a review, whenever you have some spare time

Copy link
Contributor

@ameier38 ameier38 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for PR. This would be a great addition. Could you also add the new options to the README?

Copy link
Contributor

@ameier38 ameier38 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, just one more request. Would prefer to keep the image values consistent throughout the chart. See comments.

@zetaron
Copy link

zetaron commented Jan 25, 2020

Hi @ameier38,

I'd like to ping on this PR as it's been some time since your last review.
Would this be ok to merge?

I'm asking because our team is currently running Eventstore on kubernetes and would appreciate it, if monitoring was part of the package.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants