GH-357 Add configurable duration formatter with plural support by imDMK · Pull Request #358 · EternalCodeTeam/EternalCombat

imDMK · 2026-03-05T23:37:51Z

Closes #357

Duration formatter

Introduces a configurable duration formatter with plural support and customizable separators.
Tested on localhost server.

Preview

Video

Nagranie.z.ekranu.2026-03-6.o.00.16.56.mov

…ators

gemini-code-assist · 2026-03-05T23:38:14Z

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the plugin's ability to display time-related information in a user-friendly and customizable manner. By introducing a new, configurable duration formatting service, it allows administrators to tailor how combat timers, cooldowns, and other time values are presented, improving clarity and localization without altering core logic.

Highlights

Configurable Duration Formatting: Introduced a new DurationService and DurationFormatter to provide highly configurable duration formatting with support for pluralization and custom separators, replacing the previous static utility.
New Configuration Options: Added DurationFormatSettings to the PluginConfig, allowing users to define custom patterns, separators, and zero-duration text for time displays throughout the plugin.
Integration Across Plugin Components: The new duration formatting system has been integrated into core plugin components such as CombatPlugin initialization, PlaceholderAPI integration, combat task updates, pearl cooldown messages, and tag-out commands.
Refactored Time Utility: The old DurationUtil class has been removed, streamlining the codebase and centralizing duration formatting logic within the new DurationService.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

eternalcombat-plugin/src/main/java/com/eternalcode/combat/CombatPlugin.java
- Reordered import statements for better organization
- Instantiated DurationService based on plugin configuration
- Injected DurationService into BridgeService, FightTagOutCommand, FightTask, and FightPearlController constructors
eternalcombat-plugin/src/main/java/com/eternalcode/combat/bridge/BridgeService.java
- Reordered import statements
- Added DurationService to the constructor and initialized it
- Passed durationService to the FightTagPlaceholder constructor
eternalcombat-plugin/src/main/java/com/eternalcode/combat/bridge/placeholder/FightTagPlaceholder.java
- Reordered import statements
- Added DurationService to the constructor and initialized it
- Replaced calls to DurationUtil.format with durationService.format
- Updated getAuthors().get(0) to getAuthors().getFirst() for modern Java collection access
eternalcombat-plugin/src/main/java/com/eternalcode/combat/config/implementation/CrystalPvpSettings.java
- Corrected comment formatting for consistency
eternalcombat-plugin/src/main/java/com/eternalcode/combat/config/implementation/DurationFormatSettings.java
- Added a new configuration class to define duration formatting patterns, separators, and zero-duration text
eternalcombat-plugin/src/main/java/com/eternalcode/combat/config/implementation/MessagesSettings.java
- Removed the withoutMillis boolean configuration, as formatting is now handled by DurationFormatSettings
eternalcombat-plugin/src/main/java/com/eternalcode/combat/config/implementation/PlaceholderSettings.java
- Corrected comment formatting for consistency
eternalcombat-plugin/src/main/java/com/eternalcode/combat/config/implementation/PluginConfig.java
- Added a new durationFormat field to include DurationFormatSettings in the main plugin configuration
eternalcombat-plugin/src/main/java/com/eternalcode/combat/fight/FightTask.java
- Replaced DurationUtil import with DurationService import
- Added DurationService to the constructor and initialized it
- Updated combat notification placeholder formatting to use durationService.format
eternalcombat-plugin/src/main/java/com/eternalcode/combat/fight/pearl/FightPearlController.java
- Replaced DurationUtil import with DurationService import
- Added DurationService to the constructor and initialized it
- Updated pearl cooldown message formatting to use durationService.format
eternalcombat-plugin/src/main/java/com/eternalcode/combat/fight/tagout/FightTagOutCommand.java
- Replaced DurationUtil import with DurationService import
- Added DurationService to the constructor and initialized it
- Updated tag-out command messages to use durationService.format for time display
- Renamed untagout methods to unTagout for improved naming consistency
eternalcombat-plugin/src/main/java/com/eternalcode/combat/time/DurationFormatter.java
- Added a new class responsible for parsing duration patterns and formatting Duration objects into human-readable strings with plural support and custom separators
eternalcombat-plugin/src/main/java/com/eternalcode/combat/time/DurationService.java
- Added a new service class that acts as an entry point for duration formatting, utilizing DurationFormatter and DurationFormatSettings
eternalcombat-plugin/src/main/java/com/eternalcode/combat/time/DurationUnit.java
- Added a new enum defining different time units (days, hours, minutes, seconds) and their extraction logic from a Duration object
eternalcombat-plugin/src/main/java/com/eternalcode/combat/util/DurationUtil.java
- Removed the DurationUtil class entirely, as its functionality is now superseded by the new DurationService

Activity

The pull request addresses issue [Feature]: Add extender placeholders to be used in combatNotification #357 by implementing a configurable duration formatter.
The author, imDMK, has introduced new classes (DurationFormatter, DurationService, DurationUnit, DurationFormatSettings) to handle flexible time formatting.
Existing classes have been updated to integrate the new DurationService for consistent time display.
Preview images and a video demonstrating the new duration formatter have been provided in the PR description.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request introduces a configurable duration formatter with plural support, which is a great enhancement. The implementation is mostly solid, but I've found a couple of issues. There's a bug in the new duration formatter's parsing logic that makes part of the code unreachable and prevents certain formats. Additionally, there's a potential compatibility issue with the use of a Java 21-specific method. My review includes suggestions to address these points.

...mbat-plugin/src/main/java/com/eternalcode/combat/bridge/placeholder/FightTagPlaceholder.java

eternalcombat-plugin/src/main/java/com/eternalcode/combat/time/DurationFormatter.java

Jakubk15

Looks cool!

eternalcombat-plugin/src/main/java/com/eternalcode/combat/time/DurationFormatter.java

eternalcombat-plugin/src/main/java/com/eternalcode/combat/fight/tagout/FightTagOutCommand.java

…t/tagout/FightTagOutCommand.java Co-authored-by: Jakub Kędziora <77227023+Jakubk15@users.noreply.github.com>

… feature/duration-formatter

Rollczi · 2026-03-08T18:04:25Z

eternalcombat-plugin/src/main/java/com/eternalcode/combat/time/DurationService.java

+
+import java.time.Duration;
+
+public final class DurationService {


do wywalenia klasa nic to nie robi

Rollczi · 2026-03-08T20:47:30Z

eternalcombat-plugin/src/main/java/com/eternalcode/combat/time/DurationUnit.java

+        this.symbol = symbol;
+    }
+
+    abstract long extract(Duration duration);


trochę nazwa nie jasnsa, to daje part z Duration

Rollczi · 2026-03-08T20:49:14Z

eternalcombat-plugin/src/main/java/com/eternalcode/combat/time/DurationUnit.java

+
+enum DurationUnit {
+
+    DAYS("d") {


zróbmy to bez @OverRide, można po prostu zrobić Funcation<Duration, Long> duration -> duration.toDaysPart() i do fileda zapisać

Rollczi · 2026-03-08T20:53:54Z

...lugin/src/main/java/com/eternalcode/combat/config/implementation/DurationFormatSettings.java

+        "# Example:",
+        "#  %d{day|days} %h{hour|hours} %m{minute|minutes} %s{second|seconds} %ms{millisecond|milliseconds}"
+    })
+    public String pattern = "%d {day|days} %h {hour|hours} %m {minute|minutes} %s {second|seconds} %ms {millisecond|milliseconds}";


nie możemy tego rozłożyć może na filedy typu:

days: "{x} day|{x} days"
etc etc a spacje można dać samemu tak jak tu ^
to jest troszkę lepsze bo uwzględnia lepiej jakieś dziwne cases gdzie ktoś chce mieć inne separatory albo inne głupoty

w ogóle w językach typu Polski jest problem z
1 godzina, 2 godziny, 5 godzin :/ no ale trudno będą musieli używać godz.

Rollczi · 2026-03-08T20:54:35Z

eternalcombat-plugin/src/main/java/com/eternalcode/combat/CombatPlugin.java

 import com.eternalcode.combat.fight.FightTask;
+import com.eternalcode.combat.fight.controller.*;
+import com.eternalcode.combat.fight.death.DeathEffectController;
+import com.eternalcode.combat.fight.drop.*;
+import com.eternalcode.combat.fight.drop.impl.PercentDropModifier;
+import com.eternalcode.combat.fight.drop.impl.PlayersHealthDropModifier;
+import com.eternalcode.combat.fight.effect.FightEffectController;
+import com.eternalcode.combat.fight.effect.FightEffectService;
 import com.eternalcode.combat.fight.effect.FightEffectServiceImpl;
+import com.eternalcode.combat.fight.firework.FireworkController;


cofnijmy te importy

Rollczi · 2026-03-08T20:56:42Z

...mbat-plugin/src/main/java/com/eternalcode/combat/bridge/placeholder/FightTagPlaceholder.java

    private String handleRemainingSeconds(OfflinePlayer player) {
        return this.getFightTag(player)
-            .map(tag -> DurationUtil.format(tag.getRemainingDuration()))
+            .map(tag -> durationService.format(tag.getRemainingDuration()))


ja już tu zmieniamy to przydało by się wywalić remaining_millis i remaining_seconds bo w tym kontekście te placeholdery wdają się być bez sensu

Introduce configurable duration formatter with plural forms and separ…

c81f73a

…ators

imDMK requested review from CitralFlo, Jakubk15, Rollczi, igoyek, noyzys and vLuckyyy March 5, 2026 23:37

imDMK added the 🆕 feature New feature or request label Mar 5, 2026

gemini-code-assist bot reviewed Mar 5, 2026

View reviewed changes

...mbat-plugin/src/main/java/com/eternalcode/combat/bridge/placeholder/FightTagPlaceholder.java Show resolved Hide resolved

eternalcombat-plugin/src/main/java/com/eternalcode/combat/time/DurationFormatter.java Outdated Show resolved Hide resolved

Follow Google Gemini review

7885b03

Jakubk15 approved these changes Mar 7, 2026

View reviewed changes

imDMK and others added 4 commits March 7, 2026 11:46

Follow Jakubk15 review suggestions

e64f555

Update eternalcombat-plugin/src/main/java/com/eternalcode/combat/figh…

6a02e62

…t/tagout/FightTagOutCommand.java Co-authored-by: Jakub Kędziora <77227023+Jakubk15@users.noreply.github.com>

Update eternalcombat-plugin/src/main/java/com/eternalcode/combat/figh…

01fa48c

…t/tagout/FightTagOutCommand.java Co-authored-by: Jakub Kędziora <77227023+Jakubk15@users.noreply.github.com>

Update eternalcombat-plugin/src/main/java/com/eternalcode/combat/figh…

87650c3

…t/tagout/FightTagOutCommand.java Co-authored-by: Jakub Kędziora <77227023+Jakubk15@users.noreply.github.com>

This comment was marked as resolved.

Sign in to view

imDMK added 2 commits March 8, 2026 00:14

duration: add ms unit support to duration formatter

56815d5

Merge remote-tracking branch 'origin/feature/duration-formatter' into…

96920f0

… feature/duration-formatter

Rollczi requested changes Mar 8, 2026

View reviewed changes


		import java.time.Duration;

		public final class DurationService {

Uh oh!

Conversation

imDMK commented Mar 5, 2026

Duration formatter

Preview

Video

Uh oh!

gemini-code-assist bot commented Mar 5, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Jakubk15 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment was marked as resolved.

Rollczi Mar 8, 2026

Choose a reason for hiding this comment

Uh oh!

Rollczi Mar 8, 2026

Choose a reason for hiding this comment

Uh oh!

Rollczi Mar 8, 2026

Choose a reason for hiding this comment

Uh oh!

Rollczi Mar 8, 2026

Choose a reason for hiding this comment

Uh oh!

Rollczi Mar 8, 2026

Choose a reason for hiding this comment

Uh oh!

Rollczi Mar 8, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants