-
-
Notifications
You must be signed in to change notification settings - Fork 9
GH-334 Folia pearl fix #334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
CitralFlo
wants to merge
6
commits into
master
Choose a base branch
from
folia-pearl-fix
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+60
−12
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
5511ccc
Move FoliaChecker to final class - used it in FightTagController, add…
CitralFlo a9bfe45
Make it configurable
CitralFlo 5e4ba58
Follow Gemini review
CitralFlo 403f418
Follow jakubek's review
CitralFlo 8b31db0
Remove unnecessary configuration
CitralFlo 9f0ffa5
Adjust to @imDMK review
CitralFlo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
36 changes: 36 additions & 0 deletions
36
eternalcombat-plugin/src/main/java/com/eternalcode/combat/FoliaChecker.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| package com.eternalcode.combat; | ||
|
|
||
| public final class FoliaChecker { | ||
|
|
||
| private static final String FOLIA_CLASS = "io.papermc.paper.threadedregions.RegionizedServer"; | ||
| private static Boolean isFoliaPresent = null; | ||
|
|
||
| private FoliaChecker() { | ||
| throw new UnsupportedOperationException("This is a utility class and cannot be instantiated"); | ||
| } | ||
|
|
||
| public static boolean isFolia() { | ||
| return detectFoliaEnvironment(); | ||
| } | ||
|
|
||
| private static synchronized boolean detectFoliaEnvironment() { | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. do we need synchronized here? |
||
| if (isFoliaPresent != null) { | ||
| return isFoliaPresent; | ||
| } | ||
|
|
||
| try { | ||
| Class.forName(FOLIA_CLASS); | ||
| isFoliaPresent = true; | ||
| } | ||
| catch (ClassNotFoundException exception) { | ||
| isFoliaPresent = false; | ||
| } | ||
|
|
||
| return isFoliaPresent; | ||
| } | ||
|
|
||
| public static void clearCache() { | ||
| isFoliaPresent = null; | ||
| } | ||
|
|
||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.