Support Forge 1.20.6+ and NeoForge 1.20.4+ #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Former is Forge specific, latter is ModLauncher specific, and while they tend to change at the same time, that'll no longer be true once we also consider NeoForge.
Newer Forge versions will put inner jars (such as Kotlin inside KFF) on a layer which depends on the outer jar (KFF), which may be different than what one would expect from just looking at the Kotlin jar. As such we can no longer determine the layer ahead of time and will instead assume that layers are built in order, and just assume whichever layer is the most recent one. Note that we cannot easily just check which layer our SecureJar is in because it may be further wrapped by e.g. KFFMerger and as such may not directly appear in any of the lists at all.
Will be required for KFF5 which uses JarJar, so we want to emit all our Kotlin jars separately instead of merging them into the outer jar.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits.
ML11 is required for NeoForge 1.21 (LexForge stayed on its fork of ML10).
KFF5 is required for 1.20.6+ (and is the only thing required for Forge 1.20.6+).