Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Search] Improve keyboard focus handling #335

Merged
merged 2 commits into from
May 23, 2023

Conversation

dfeinzimer
Copy link
Collaborator

@dfeinzimer dfeinzimer commented May 19, 2023

Related #7

When a search suggestion or result is tapped, the keyboard remains focused, leaving less room for the map with pin(s) and signaling to the user more text entry is expected.

A common pattern pattern seems to be that the keyboard is hidden once a result or suggestion is tapped.

This PR changes the search component to follow that latter common pattern.

@dfeinzimer dfeinzimer requested a review from mhdostal May 19, 2023 01:35
@dfeinzimer dfeinzimer self-assigned this May 19, 2023
@dfeinzimer dfeinzimer marked this pull request as ready for review May 19, 2023 17:53
@dfeinzimer dfeinzimer merged commit 26521ed into v.next May 23, 2023
@dfeinzimer dfeinzimer deleted the df/improveSearchTextFocus branch May 23, 2023 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants