-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trace UI enhancements #788
Open
shubham7109
wants to merge
7
commits into
v.next
Choose a base branch
from
shubham/trace-ui-changes
base: v.next
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion and results screen
sorenoid
reviewed
Mar 25, 2025
@@ -106,7 +106,6 @@ private fun TraceScaffold( | |||
Surface( | |||
color = MaterialTheme.colorScheme.surface, | |||
modifier = modifier | |||
.fillMaxSize() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In addition to removing this line, consider editing TraceScaffold
to provide a default parameter modifier = Modifier.fillMaxSize()
. Current behavior would be preserved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to issue: #5512
Description:
PR to update the UtilityNetworkTrace tool's UI to handle user Modifier content sizes dynamically. (
fillMaxSize
&wrapContentSize
etc). Currently, afillMaxSize
Modifier is hard-coded within theTrace
surface scaffold.This PR aims to update the UI to adapt the
Trace
composable to react dynamically towards constraint sizes between Modifier content size changes, and TraceNavigation composable content changes.Summary of changes:
fillMaxSize
fromTraceScaffold
fillMaxSize
fromStartingPointRow
sizeTransform
to theNavHost
to be able to react to content size changes like between theTraceOptionsScreen -> AddStartingPointScreen -> TraceOptionsScreen
weight
to the LazyColumn inTraceOptionsScreen
such that the "Trace" button is always visible in the content.weight
to the LazyColumn inTraceResultScreen
such that the "Clear all results" button is always visible in the content.Test code
Pre-merge Checklist