Pass ar_relation to should_require_tenant? for improved control
#349
+33
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikraamg
force-pushed
the
Pass-the-ar-relation-for-context-to-should_require_tenant
branch
from
3a1c678 to
a59c5d9
Compare
ikraamg
changed the title
should_require_tenant? for improved controlshould_require_tenant? for improved control
ikraamg
force-pushed
the
Pass-the-ar-relation-for-context-to-should_require_tenant
branch
from
a59c5d9 to
3b5b9d0
Compare
This is a backwards compatible addition that allows finer control over when `ActsAsTenant::Errors::NoTenantSet` is raised in the default scope check.
ikraamg
force-pushed
the
Pass-the-ar-relation-for-context-to-should_require_tenant
branch
from
3b5b9d0 to
530effc
Compare
|
Hey @excid3, lovely to be in contact! Could you please take a peek at this when you have some time 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhance the
should_require_tenant?method to accept a context parameter, allowing for more granular control over tenant requirements.This change maintains backward compatibility while enabling the evaluation of conditions based on the provided on the ar_relation object.