Draft
Conversation
Add new android-sdk-framework module that provides base client functionality and configuration storage abstractions for Android SDK implementations. Key components: - AndroidBaseClient: Base class for Android SDK clients - CachingConfigurationStore: Abstract store for cached configurations - FileBackedConfigStore: File-based configuration persistence - ConfigurationCodec: Pluggable serialization/deserialization - ByteStore: Low-level byte storage abstraction This module uses the v4 Java SDK framework and is added as a standalone module without integration into the existing eppo module yet.
The v4 framework snapshots are deployed to the new Maven Central snapshot repository at https://central.sonatype.com/repository/maven-snapshots, not the old OSSRH at https://oss.sonatype.org/content/repositories/snapshots/
…ation)
Migrate EppoClient from v3 SDK to v4 framework, resolving all test failures.
## Major Changes
### EppoClient Migration
- Extend AndroidBaseClient from framework instead of BaseEppoClient
- Remove old ConfigurationStore, ConfigCacheFile, BaseCacheFile (now in framework)
- Add dependency on android-sdk-framework module
- Remove v3 sdk-common-jvm dependency
### New Components
- OkHttpEppoClient: HTTP client implementation with logging
- JacksonConfigurationParser: JSON parsing for v4 format
- Jackson adapters for EppoValue, FlagConfigResponse, dates, etc.
### Test Infrastructure Fixes
- TestConfigCacheFile: Fix filename to match framework (eppo-sdk-flags-{suffix}.ser)
- Fix waitForPopulatedCache(): Remove incorrect .ser suffix (already in filename)
- Fix unclosed OutputStreams: Add try-with-resources (3 locations)
- Simplify testDifferentCacheFilesPerKey: Copy actual cache instead of custom JSON
- Add OutputStream import
### Example App Updates
- Add CustomClientActivity demonstrating custom HTTP client
- Add GsonConfigurationParser and HeaderInjectingEppoClient examples
## Test Results
- All 46 instrumentation tests passing locally
- Framework module builds independently
- Eppo module builds with v4 dependencies
- Fix TestConfigCacheFile.cacheFileName() to use correct format (eppo-sdk-flags-{suffix}.ser)
- Simplify testDifferentCacheFilesPerKey to copy actual cache instead of custom JSON
- Fix unclosed OutputStreams with try-with-resources (3 locations)
These fixes resolve all test failures and ensure 46/46 tests pass.
…I 26-32 compatibility
…or handling - Move GsonConfigurationCodec to example module (it's a demo/example codec, not part of the framework public API) - Update CustomClientActivity to use GsonConfigurationCodec + FileBackedConfigStore to demonstrate human-readable JSON cache - Fix initialization error handling in AndroidBaseClient and EppoClient: complete exceptionally when ex != null, avoiding double increment of failCount
- eppo: 4.12.1 -> 4.12.1-SNAPSHOT - android-sdk-framework: 0.1.0 -> 0.1.0-SNAPSHOT - Remove duplicate sdk-common-jvm implementation dependency (already declared as api) - Update publish-snapshot workflow to stage and publish android-sdk-framework before eppo, so the transitive dependency is resolvable by customers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Eppo Internal:
🎟️ Fixes issue
📜 Design Doc: link if applicable
Motivation and Context
Description
How has this been documented?
How has this been tested?