[build_local] Symlink libdevice and fatbinary for GPU builds
#1579
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1579 +/- ##
===========================================
+ Coverage 21.66% 40.00% +18.33%
===========================================
Files 46 124 +78
Lines 8048 22068 +14020
===========================================
+ Hits 1744 8828 +7084
- Misses 6304 13240 +6936 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
should we switch our local libReactant runners to only use the gcp runners? |
|
Yes |
giordano
force-pushed
the
mg/libdevice
branch
8 times, most recently
from
43f0c9a to
e3f0b8e
Compare
giordano
added a commit
to giordano/Enzyme-JAX
that referenced
this pull request
Aug 23, 2025
giordano
added a commit
to giordano/Enzyme-JAX
that referenced
this pull request
Aug 23, 2025
|
Confirmed to work in EnzymeAD/Enzyme-JAX#1338. Changes to CI setup were taken out in #1584 |
wsmoses
approved these changes
Aug 23, 2025
|
We also might need to symlink fatbin as well |
giordano
changed the title
libdevice to appropriate pathlibdevice and fatbinary for GPU builds
wsmoses
approved these changes
Aug 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm testing something along these lines in EnzymeAD/Enzyme-JAX#1335.