Skip to content

Adding leader ban registry module in supra framework #290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 12 commits into
base: dev
Choose a base branch
from
Open

Adding leader ban registry module in supra framework #290

wants to merge 12 commits into from
+2,213 −6

Conversation

@dhaval-supraoracles
Copy link

No description provided.

isaacdoidge
isaacdoidge reviewed Sep 22, 2025
View reviewed changes
Copy link

@isaacdoidge isaacdoidge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A good start, the config pattern is nice. There's still quite a bit to do in the registry itself though. If you haven't already read the Rust code thoroughly then please do so.

isaacdoidge
isaacdoidge reviewed Oct 2, 2025
View reviewed changes
Copy link

@isaacdoidge isaacdoidge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! A few more things to adjust though.

isaacdoidge
isaacdoidge reviewed Oct 3, 2025
View reviewed changes
Copy link

@isaacdoidge isaacdoidge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few things need to be fixed.

isaacdoidge
isaacdoidge reviewed Oct 6, 2025
View reviewed changes
isaacdoidge
isaacdoidge reviewed Oct 20, 2025
View reviewed changes
Copy link

@isaacdoidge isaacdoidge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but please extend the e2e test. It should cover more functionality.

@dhaval-supraoracles dhaval-supraoracles marked this pull request as ready for review October 24, 2025 05:40
@dhaval-supraoracles dhaval-supraoracles changed the title WIP: adding leader ban registry module in supra framework Adding leader ban registry module in supra framework Oct 24, 2025
isaacdoidge
isaacdoidge reviewed Oct 24, 2025
View reviewed changes
Copy link

@isaacdoidge isaacdoidge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Just a couple more things to address.

aptos-move/framework/supra-framework/sources/leader_ban_registry.move Outdated
});
if (is_banned) {
let bans = vector::borrow_mut(&mut ban_registry.bans, index);
bans.consecutive_bans = bans.consecutive_bans + 1;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to reset all fields of bans.active here as well. The ban duration should reset each time the validator is banned.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then the test cases that I have written will not work
is it intended?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your test cases should test ban expiry by incrementing the current view without re-banning the validator that should be re-admitted to the validator set. Each time a validator is banned, its ban period should reset, so a validator can only be reinstated if it does not earn any new bans until its current ban period ends.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@isaacdoidge isaacdoidge isaacdoidge left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dhaval-supraoracles @isaacdoidge