Add node_kind checks on verify command #6934
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the expected output for node_kind verify check, merged in PR EnterpriseDB/bdr#4229
| Witness-only groups Ok | ||
| Data nodes per group Ok | ||
| Empty groups Ok | ||
| Nodes have node kind set Ok |
There was a problem hiding this comment.
Why is the "set" in blue? Is it expected in the output?
There was a problem hiding this comment.
Not sure why it is shown like that, perhaps a reserved work for that component? (the output line did not have it)
So it should not be displayed like that.
nidhibhammar
added
the
deploy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the expected output for node_kind verify check, merged in PR https://github.com/EnterpriseDB/bdr/pull/4229
What Changed?
The new standard output of
cluster verifyshould include a new check message after the last one 'Empty groups'