Skip to content

[115] Hide unneeded ancestral genome sequence #1078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

twalsh-ebi
Copy link
Contributor

Description

PR ensembl-webcode PR 155 implemented functionality to "Remove the unneeded ancestral species from the sequence view".

The intended behaviour was that in ancestral alignment views (e.g. EPO), hiding all the extant genomes descending from a child of an ancestral sequence would result in that ancestral sequence also being hidden.

The most recent release with this behaviour was Ensembl 104: https://may2021.archive.ensembl.org/Homo_sapiens/Location/Compara_Alignments/Image?align=1944&db=core&r=17%3A63992802-64038237

This pull request would restore that behaviour.

Views affected

This change would affect EPO alignments in Ensembl Vertebrates.

The following example images show the effect of the change when Mouse lemur is hidden in the Primates EPO alignment views.

Example image alignment view before change (with unneeded ancestral sequence displayed):
primates_epo_image_alignment_before

Example image alignment view after change:
primates_epo_image_alignment_after

Example text alignment view before change (with unneeded ancestral sequence displayed):
primates_epo_text_alignment_before

Example text alignment view after change:
primates_epo_text_alignment_after

Possible complications

This PR would change the return value of method EnsEMBL::Web::Object::get_alignments to include the relevant $align_slice object. All known invocations of this method have been adapted in the PR, but it's possible that other invocations of the method would need to be adapted in response to the change in this method's behaviour.

Merge conflicts

None detected.

Related JIRA Issues (EBI developers only)

N/A

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant