[115] Hide unneeded ancestral genome sequence #1078
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR ensembl-webcode PR 155 implemented functionality to "Remove the unneeded ancestral species from the sequence view".
The intended behaviour was that in ancestral alignment views (e.g. EPO), hiding all the extant genomes descending from a child of an ancestral sequence would result in that ancestral sequence also being hidden.
The most recent release with this behaviour was Ensembl 104: https://may2021.archive.ensembl.org/Homo_sapiens/Location/Compara_Alignments/Image?align=1944&db=core&r=17%3A63992802-64038237
This pull request would restore that behaviour.
Views affected
This change would affect EPO alignments in Ensembl Vertebrates.
The following example images show the effect of the change when Mouse lemur is hidden in the Primates EPO alignment views.
Example image alignment view before change (with unneeded ancestral sequence displayed):

Example image alignment view after change:

Example text alignment view before change (with unneeded ancestral sequence displayed):

Example text alignment view after change:

Possible complications
This PR would change the return value of method
EnsEMBL::Web::Object::get_alignments
to include the relevant$align_slice
object. All known invocations of this method have been adapted in the PR, but it's possible that other invocations of the method would need to be adapted in response to the change in this method's behaviour.Merge conflicts
None detected.
Related JIRA Issues (EBI developers only)
N/A