Load underlying slices iff needed for alignslice view #1076
+3
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
On
line 390 of ensembl-webcode/modules/EnsEMBL/Web/Object.pm
...ensembl-webcode/modules/EnsEMBL/Web/Object.pm
Line 390 in 370648c
...in method
EnsEMBL::Web::Object::get_slices
, the'image'
parameter is used to control whetherunderlying_slices
of a ComparaAlignSlice::Slice
are loaded for a formatted slice.The loaded
underlying_slices
value is used in various places in text alignment views. However, in genomic alignment image (alignslice) views, it appears to be used only to control visibility of ancestral sequences, in line 417 ofensembl-webcode/modules/EnsEMBL/Web/Object.pm
:ensembl-webcode/modules/EnsEMBL/Web/Object.pm
Line 417 in 370648c
This PR would set the
get_slices
'image'
parameter to0
for genomic alignment image views lacking an ancestral sequence (i.e. not of classGenomicAlignTree.ancestral_alignment
). In tests done so far on the 91 Mammals EPO-Extended alignment, this has reduced loading times by ~10% on average.Views affected
This change would affect image (alignslice) views of all non-ancestral genomic alignments, including EPO-Extended, Cactus and LastZ alignments.
Further details on testing are available in the related Jira ticket.
Possible complications
This is not expected to adversely affect any views. The change is restricted to non-ancestral image alignments, where the
underlying_slices
value is not currently needed.Merge conflicts
None detected.
Related JIRA Issues (EBI developers only)