Skip to content

Load underlying slices iff needed for alignslice view #1076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 29, 2025

Conversation

twalsh-ebi
Copy link
Contributor

@twalsh-ebi twalsh-ebi commented Apr 28, 2025

Description

On line 390 of ensembl-webcode/modules/EnsEMBL/Web/Object.pm ...

my $underlying_slices = !$args->{image}; # Don't get underlying slices for alignment images - they are only needed for text sequence views, and the process is slow.

...in method EnsEMBL::Web::Object::get_slices, the 'image' parameter is used to control whether underlying_slices of a Compara AlignSlice::Slice are loaded for a formatted slice.

The loaded underlying_slices value is used in various places in text alignment views. However, in genomic alignment image (alignslice) views, it appears to be used only to control visibility of ancestral sequences, in line 417 of ensembl-webcode/modules/EnsEMBL/Web/Object.pm:

my $ga_node = $formatted_slices[-1]->{underlying_slices}->[0]->{_node_in_tree};

This PR would set the get_slices 'image' parameter to 0 for genomic alignment image views lacking an ancestral sequence (i.e. not of class GenomicAlignTree.ancestral_alignment). In tests done so far on the 91 Mammals EPO-Extended alignment, this has reduced loading times by ~10% on average.

Views affected

This change would affect image (alignslice) views of all non-ancestral genomic alignments, including EPO-Extended, Cactus and LastZ alignments.

Further details on testing are available in the related Jira ticket.

Possible complications

This is not expected to adversely affect any views. The change is restricted to non-ancestral image alignments, where the underlying_slices value is not currently needed.

Merge conflicts

None detected.

Related JIRA Issues (EBI developers only)

  • ENSCOMPARASW-8396

@twalsh-ebi twalsh-ebi marked this pull request as ready for review April 28, 2025 14:35
@azangru azangru merged commit 2250d93 into Ensembl:postreleasefix/114 Apr 29, 2025
azangru pushed a commit that referenced this pull request Apr 29, 2025
* postreleasefix/114:
  Tweak handling of strain, Pan and subtree export (#1074)
  Load underlying slices iff needed for alignslice view (#1076)
  Update Apache access logs format: print request ips (#1077)
azangru pushed a commit that referenced this pull request Apr 29, 2025
* postreleasefix/114:
  Tweak handling of strain, Pan and subtree export (#1074)
  Load underlying slices iff needed for alignslice view (#1076)
  Update Apache access logs format: print request ips (#1077)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants