Draft
Conversation
Adding/Removing custom domains are now in /rg addmember/delmember/addowner/delowner
acecbb6 to
2dff680
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a draft pr because:
CustomDomains. It should be done using an additional internalDomain.CustomDomains) to demonstrate the idea.However, feedback regarding the idea is welcome.
The idea:
The nonplayer-protection-domains flag currently only works bidirectional. If two regions share a domain, non-players that are members of the first region can build in the second region and vice versa. This pr generalizes the nonplayer-protection-domains flag even more and makes it much more flexible and powerful. With this pr the nonplayer-protection-domains flag does nothing by its own. It's just used to setup the domains. This pr adds the abillity to add non-players (nonplayer-protection-domains) as members or owners to regions. (On a side note: With this feature it's even safe to let players setup their non-player members by themselves, since it only affects their own regions and not vice versa as described above. Though, the feature is probably too complicated for regular players.)
I have also implemented an example usecase as demonstration for the feature. If enabled, the
regions.nonplayer-border-bypass-on-claimsetting automatically adds claimed regions to a non-player protection domain (player uuid) and adds the domain as owner to the claim. As a result, if a player owns two claims next to each other, there is no border for non-player associables. (Of course owners must be aware that adding further player members to a single region is dangerous, because they can modify other regions too via non-player associables.)