Merge manifests for hybrid mod jar #2457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
octylFractal
approved these changes
Jan 24, 2024
See if this makes CI happy Try this on CI It seems to mistake the second arg as the wrong type, so split them up Fix formatting Switch to shadowJar as it's now miraculously working
me4502
force-pushed
the
fix/hybrid-mod-forge-mixin-manifest
branch
from
e850871 to
8d2429a
Compare
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This appears to fix #2442 for 7.2.x. The issue reports further issues on 7.3, so my plan is to get this into 7.2.x, merge that into master, and then fix the lack of refmap.
This has been tested by ensuring that it mentions mixins during startup, and that the UPDATE flag is both present and functional (as that's dependent on mixins). I did not encounter the mixin failures that were mentioned in the linked issue, that might have been specific to the prior version used.