-
Notifications
You must be signed in to change notification settings - Fork 13
improve docker image script #394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@@ -12,7 +12,7 @@ platform( | |||
"@rules_go//go/toolchain:cgo_off", | |||
], | |||
exec_properties = { | |||
"container-image": "docker://645088952840.dkr.ecr.eu-west-1.amazonaws.com/engflow-re/windows-x64:engflow_worker@sha256:6a53c6d5cbc82ca0782e9117482e457a676920227b697de5db90ff53e7afedbe", | |||
"container-image": "<YOUR_WINDOWS_CONTAINER_IMAGE_URI>", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this because of security reasons?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh wait. It looks like we don't run against windows (I think we did before)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please keep this: it's not an example, it's meant to be used in production, even if we're not doing that right now.
@@ -12,7 +12,7 @@ platform( | |||
"@rules_go//go/toolchain:cgo_off", | |||
], | |||
exec_properties = { | |||
"container-image": "docker://645088952840.dkr.ecr.eu-west-1.amazonaws.com/engflow-re/windows-x64:engflow_worker@sha256:6a53c6d5cbc82ca0782e9117482e457a676920227b697de5db90ff53e7afedbe", | |||
"container-image": "<YOUR_WINDOWS_CONTAINER_IMAGE_URI>", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please keep this: it's not an example, it's meant to be used in production, even if we're not doing that right now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is based on an internal script docker_build.ps1
. Let's keep these in sync. Please update that one first and verify docker build
works.
trap {}
statement by changing it to atry...catch
$repoRootDir = Get-Location
was invoked, the error would get masked by another error from within thetrap
handler