Draft: Add Vodacom Mobile Money integration package #520
Conversation
beesaferoot
changed the title
|
This is a Draft PR to setup a plugin. Your reviews are welcome |
|
Nice @beesaferoot I like it a lot!! @93Kamuran could you please review the Plugin Development guide? And let us know that this is the process you currently follow when developing a plugin for MPM? |
|
The goal this is to move the Vodacom dummy endpoints into a plugin, right? I would have expected this PR to then remove the code that we added previously, no? |
Yeah, I will be doing so with this. I wanted to get feedback first before going too deep. |
…outes and files, and improve formatting
beesaferoot
force-pushed
the
setup-vodacom-plugin
branch
from
6540cf7 to
6706d8a
Compare
| @@ -2,9 +2,7 @@ | |||
|
|
|||
There was a problem hiding this comment.
We will remove this controller. In #526
| @@ -0,0 +1,19 @@ | |||
| <?php | |||
There was a problem hiding this comment.
I think we're gonna resolve companyId from JTW token in request instead from url segment. However, it's okay for draft.
| @@ -0,0 +1,24 @@ | |||
| <?php | |||
There was a problem hiding this comment.
Let's add a status column here, that could be an enum as ['pending','succeeded','failed'] or [0,1,-1]
| @@ -332,9 +332,3 @@ static function () { | |||
| Route::group(['prefix' => 'usage-types'], static function () { | |||
There was a problem hiding this comment.
these routes will have been removed in #526
Brief summary of the change made
Are there any other side effects of this change that we should be aware of?
Describe how you tested your changes?
Pull Request checklist
Please confirm you have completed any of the necessary steps below.