Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace vue-sweetalert2 with vue-material dialogs #498

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

munyanezaarmel
Copy link
Contributor

@munyanezaarmel munyanezaarmel commented Feb 20, 2025

Brief summary of the change made

Replace vue-sweetalert2 with vue-material dialogs

closes: #174

Are there any other side effects of this change that we should be aware of?

Describe how you tested your changes?

image

Pull Request checklist

Please confirm you have completed any of the necessary steps below.

  • Meaningful Pull Request title and description
  • Changes tested as described above
  • Added appropriate documentation for the change.
  • Created GitHub issues for any relevant followup/future enhancements if appropriate.

@dmohns
Copy link
Member

dmohns commented Feb 20, 2025

Hey @munyanezaarmel

Could you provide a bit more context what is happening here? Our overarching goal is to fully remove vue-sweetalert2 dependency. This PR is removing only from a part, right?

Could you also add a screenshot how the new way looks like?

@dmohns
Copy link
Member

dmohns commented Feb 26, 2025

Hey @munyanezaarmel

Is this change fully removing our dependency on vue-sweetalert2 ? Could you remove it from our package.json file then? Or is it just a first step?

@dmohns
Copy link
Member

dmohns commented Mar 11, 2025

Hey @munyanezaarmel this looks quite good. Before I review it, can you fix the lint? You need to provide other translations for fr and bu. Feel free to just use Google Translate.

@dmohns
Copy link
Member

dmohns commented Mar 11, 2025

Also, what is still missing is to fully uninstall vue-sweetalert2 using

npm uninstall vue-sweetalert2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace vue-sweetalert2 with vue-material dialogs
2 participants