Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug fixes: Ensure agent transactions exists while seeder #477

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

beesaferoot
Copy link
Contributor

Brief summary of the change made

With this PR, we add more records to the agent balance history while also ensuring agents have transactions.

Closes: #475

Are there any other side effects of this change that we should be aware of?

Describe how you tested your changes?

Pull Request checklist

Please confirm you have completed any of the necessary steps below.

  • Meaningful Pull Request title and description
  • Changes tested as described above
  • Added appropriate documentation for the change.
  • Created GitHub issues for any relevant followup/future enhancements if appropriate.

@beesaferoot beesaferoot requested a review from dmohns February 5, 2025 11:02
@dmohns
Copy link
Member

dmohns commented Feb 5, 2025

Hey @beesaferoot

Even with this change the generated data is utterly inconsistent.

I think we need to need to look at the different Agent balance entries individually (as they function differently).

Agent Transactions: These are already getting generated in Transaction seeder. However, they are not correctly linked to Agent Balances.

Agent Charges: This already happens in Agent seeder, I think we don't need to add them a second time.

Agent Receipt: It is not clear to me what an Agent Receipt even is. Maybe we can ignore this for now, until we have clarity. I created #478 to follow up

Agent Commission: Again, this is not fully clear to me. I would assume commission is somehow related to Sold and Assigned appliances. Probably generating reasonable demo data for this is quite complicated 😅

@beesaferoot
Copy link
Contributor Author

I think we need to need to look at the different Agent balance entries individually (as they function differently).

Okay, this is something I will need to carefully look into. There is a bit of missing context with how they are all applied to the Agent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Agent transaction and balance seeding not functional
2 participants