refactor: Consolidate dbproxy and user models #461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
munyanezaarmel
previously approved these changes
Jan 20, 2025
beesaferoot
force-pushed
the
consolidate-databaseproxy-user-tables
branch
from
d189215 to
220e96c
Compare
beesaferoot
force-pushed
the
consolidate-databaseproxy-user-tables
branch
2 times, most recently
from
6a73ced to
c2293eb
Compare
beesaferoot
force-pushed
the
consolidate-databaseproxy-user-tables
branch
from
c2293eb to
3dc117a
Compare
|
@dmohns Can you take a look at this when you find the time. Thanks |
beesaferoot
force-pushed
the
consolidate-databaseproxy-user-tables
branch
from
529a885 to
fc55789
Compare
Update on this: this has been resolved by filtering the users based on their associated company id, that is admin user can only see users associated with the company id. |
With this refactor we migrate User model to the root micropowermanager database. Following, we consolidate database proxy model by resolving company id from user table directly from database proxy services. Consideration for this refactor is that, admin users can see every user on the users table from the user management admin page. This might have the effect or leaking admin accounts to other admin user.
beesaferoot
force-pushed
the
consolidate-databaseproxy-user-tables
branch
from
fc55789 to
f8f91d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief summary of the change made
With this refactor we migrate User model to the root micropowermanager database. Following, we consolidate database proxy model by resolving company id from user table directly from database proxy services.
Consideration for this refactor is that, admin users can see every user on the users table from the user management admin page.
This might have the effect or leaking admin accounts to other admin user.
Closes: #267
Are there any other side effects of this change that we should be aware of?
Describe how you tested your changes?
Pull Request checklist
Please confirm you have completed any of the necessary steps below.