Skip to content

Conversation

xuhuanzy
Copy link
Member

No description provided.

Copy link

Summary of Changes

Hello @xuhuanzy, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly extends the EmmyLua parser by integrating a new attribute feature. This allows for more expressive and structured documentation within Lua code, enabling developers to define custom metadata tags and apply them to code elements. The changes involve updates across the lexer, parser, and syntax definitions to support both the declaration and application of these attributes, complete with argument parsing.

Highlights

  • New Attribute Feature: Introduced the attribute feature, allowing users to define custom attributes (---@attribute) and apply them (---@[attribute_name(params)]) within LuaDoc comments.
  • Parser Extensions: Added new syntax kinds and parsing logic to emmylua_parser to correctly interpret attribute definitions and their usage, including attribute names and argument lists.
  • Lexer Updates: Enhanced the LuaDoc lexer with new token kinds and a dedicated state (AttributeUsage) to accurately tokenize the new attribute syntax.
  • Test Coverage: Included a new test case to ensure the proper parsing and Abstract Syntax Tree (AST) generation for the attribute feature.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@xuhuanzy xuhuanzy marked this pull request as draft September 22, 2025 21:21
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new attribute feature, allowing for attribute definitions with ---@attribute and their usage with ---@[...]. The implementation spans across the lexer, parser, and syntax kinds, and includes a new test case.

The changes are well-structured. I've found one area in the attribute argument list parsing where the code can be simplified by removing redundant whitespace handling and clarifying the loop logic.

@xuhuanzy xuhuanzy linked an issue Sep 23, 2025 that may be closed by this pull request
@xuhuanzy xuhuanzy marked this pull request as ready for review September 24, 2025 15:26
@xuhuanzy xuhuanzy force-pushed the attribute branch 2 times, most recently from 6ef8e54 to fad91a0 Compare September 24, 2025 21:01
@xuhuanzy xuhuanzy requested a review from CppCXY September 24, 2025 22:18
@xuhuanzy xuhuanzy force-pushed the attribute branch 4 times, most recently from cfd2d7e to a25a73c Compare September 29, 2025 21:32
@xuhuanzy
Copy link
Member Author

xuhuanzy commented Sep 29, 2025

@taminomara Do you know how to add a deprecation marker to the JSON schema when removing the Rust configuration item?
788eb1e remove runtime.class_default_call

@taminomara
Copy link
Contributor

Keep it in the config and add #[deprecated = "reason"].

@xuhuanzy xuhuanzy marked this pull request as draft September 30, 2025 13:07
@xuhuanzy xuhuanzy marked this pull request as ready for review September 30, 2025 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implementing new syntax: Attribute Class constructor and instantiation function definition
2 participants