Skip to content

Move top-level crates into crates/ folder #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 0 commits into from
Closed

Move top-level crates into crates/ folder #173

wants to merge 0 commits into from

Conversation

XAMPPRocky
Copy link
Member

Implements the crates part of #170

@XAMPPRocky XAMPPRocky requested a review from khyperia October 29, 2020 09:44
khyperia
khyperia approved these changes Oct 29, 2020
View reviewed changes
Copy link
Contributor

@khyperia khyperia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I just noticed the links in docs/src/introduction.md are rather out of date, they used to link to folders in the repo, but... the rendered doc isn't even in the repo anymore! Can fix this now or later.

@XAMPPRocky
Copy link
Member Author

@khyperia Updated

@XAMPPRocky XAMPPRocky added the s: waiting on author PRs that blocked on the author implementing feedback. label Oct 30, 2020
@repi
Copy link
Contributor

repi commented Oct 31, 2020

This has to be rebased/merged with latest main a lot of diffs from it. May be easiest to just do re-do it quickly and get it in? As things are moving fast it is hard to have larger refactors in PRs

@XAMPPRocky XAMPPRocky closed this Nov 2, 2020
@XAMPPRocky
Copy link
Member Author

Welp, somehow that force push closed the PR. I'll open a new one. I was waiting for #109 to land since moving the crates updates the examples.

@XAMPPRocky XAMPPRocky mentioned this pull request Nov 2, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@khyperia khyperia khyperia approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
s: waiting on author PRs that blocked on the author implementing feedback.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@XAMPPRocky @repi @khyperia