Fix auto-formatting on save breaking Parcel's watch mode#192
Closed
aforemny wants to merge 1 commit intoElmCast:masterfrom
Closed
Fix auto-formatting on save breaking Parcel's watch mode#192aforemny wants to merge 1 commit intoElmCast:masterfrom
aforemny wants to merge 1 commit intoElmCast:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
as mentioned in #160 this is still an issue (tested with Parcel 1.12.4). Contrary to #96 this should not have any such ramifications.
I think in general this solution would be more robust than the rename-based solution with respect to file watches which are often inode based.
Would you need any additional information to merge this?