Draft
Conversation
- TableWeightedRandom class works like the Climate weighting works - LinearWeightedRandom class is like the previous WeightedRandom - WeightedShuffler class has Random.Shuffle-like behavior, while also taking into account the stored weights for sorting
- Instead of picking a room from the pool and then removing all its variants - which gives a 5x chance for a 5 variant room to appear - we're picking one variant of each duplicate group at the start of palace generation. - Probably fixed the other no duplicates flag as it was comparing by object reference - Remove unnecessary while placed loop in Sequential that always ran at most once
(This applies to CoordinatePalaceGenerator only.) - If the roll fails, that palace's drops must have a way back to the entrance - just like when palaces continue after the boss. - Flipped the bool argument to HasInescapableDrop to prevent excessive double negations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(This builds on the weights PR)
Remove room selection bias for rooms with multiple variants
Extract abstract ShapeCoordinatePalaceGenerator from RandomWalk
Only minor thing here is there is one less check that the room pool contains a drop stub since the room pool is not known in that logic.
Try running FillShapeWithRooms a few times before giving up
Update: added
Add a roll for whether palaces may have one-way drops to bosses