Change set +x to set -x in CI wasm steps
#74
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems like it was intended to be `set -x`, but let's first see if it is doing something important by checking for any change when removing it.
`set +x` is the default (in general, as well as in GitHub Actions unless the value of `shell` is modified with `-x` or `-o xtrace`). What is needed to distinguish which command from which iterations of the loops in the WASM jobs' steps' output is `set -x`.
This comment was marked as resolved.
This comment was marked as resolved.
EliahKagan
added a commit
that referenced
this pull request
Aug 2, 2025
These steps benefit from showing the `cargo` command that was run before the resulting build output. Most run multiple `cargo build` commands, sometimes in a loop, such that the output can only be properly understood if the commands are shown. `set +x` is the default (in general, as well as in GitHub Actions unless the value of `shell` is modified with `-x` or `-o xtrace`). It looks like `set -x` was already intended here. Work in GitoxideLabs#2093 confirms a practical benefit of `-x` for understanding these logs. `set +x` was part of the original code of these CI steps when they were introduced in 0d4b804 (GitoxideLabs#735). Its use was preserved and expanded in several changes. In 44ff412 (GitoxideLabs#1668), `set +x` was preserved and also positioned where it would make sense for `set -x` to be. Thus, it appears this started as a small typo and gradually expanded through misreadings, including my own. This fixes that. (See #74 for verification that `set +x` had no effect.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fork-internal PR does something in two steps that should be done in one, because there is a small possibility of interest in the effect of the first step. I will squash and merge it into its target branch, which is itself a feature branch, and then I'll open a PR on the upstream repository from that branch.
These steps benefit from showing the
cargocommand that was run before the resulting build output. Most run multiplecargo buildcommands, sometimes in a loop, such that the output can only be properly understood if the commands are shown.set +xis the default (in general, as well as in GitHub Actions unless the value ofshellis modified with-xor-o xtrace). It looks likeset -xwas already intended here. Work in GitoxideLabs#2093 confirms a practical benefit of-xfor understanding these logs.set +xwas part of the original code of these CI steps when they were introduced in 0d4b804 (GitoxideLabs#735). Its use was preserved and expanded in several changes. In 44ff412 (GitoxideLabs#1668),set +xwas preserved and also positioned where it would make sense forset -xto be. Thus, it appears this started as a small typo and gradually expanded through misreadings, including my own. This fixes that.(See #74 for verification that
set +xhad no effect.)