pset: blind: return ephemeral private key#243
Merged
apoelstra merged 5 commits intoElementsProject:masterfrom Aug 13, 2025
Merged
pset: blind: return ephemeral private key#243apoelstra merged 5 commits intoElementsProject:masterfrom
apoelstra merged 5 commits intoElementsProject:masterfrom
Conversation
Member
|
In a followup (or another commit, in case you get to this before I merge it), we should refactor I think maybe I'm not married to these names, but I think they're clearer than |
Contributor
Author
|
Refactored I've no strong opinion on the name, rn I can't think of something better than |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now we have:
Transaction::blindreturns abf, vbf and ephemeral private keyPartiallySignedTransaction::blind_non_lastreturns abf and vbfPartiallySignedTransaction::blind_lastreturns nothingThis PR makes things more consistent and makes ephemeral keys more easily accessible.
It's a breaking change, but it's just augmenting the data, so it should be easy to handle downstream.