Skip to content

pytest: test spliceout exceeds channel balance #9042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
enaples wants to merge 3 commits into
base: master
Choose a base branch
from
+15 −2
Open

pytest: test spliceout exceeds channel balance #9042

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6a03a8c
pytest: test spliceout exceeds channel balance
enaples Apr 9, 2026
349934a
pytest: add missing test description
enaples Apr 10, 2026
63b6871
splicescript: Fix memleak during error
ddustin Apr 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion plugins/spender/splice.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,7 @@ static struct command_result *do_fail(struct command *cmd,
"splice_error(psbt:%p, splice_cmd:%p, str: %s)",
splice_cmd->psbt, splice_cmd, str ?: "");

abort_pkg = tal(cmd->plugin, struct abort_pkg);
abort_pkg = tal(cmd, struct abort_pkg);
abort_pkg->splice_cmd = tal_steal(abort_pkg, splice_cmd);
abort_pkg->str = tal_strdup(abort_pkg, str);
abort_pkg->code = code;
Expand Down
15 changes: 14 additions & 1 deletion tests/test_splice.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
from fixtures import * # noqa: F401,F403
from pathlib import Path
from pyln.client import Millisatoshi
from pyln.client import RpcError, Millisatoshi
import pytest
import re
import unittest
Expand Down Expand Up @@ -716,3 +716,16 @@ def test_easy_splice_out_into_channel(node_factory, bitcoind, chainparams):

end_chan1_balance = Millisatoshi(bkpr_account_balance(l2, chan1))
assert initial_chan1_balance + Millisatoshi(spliceamt * 1000) == end_chan1_balance


@pytest.mark.openchannel('v1')
@pytest.mark.openchannel('v2')
@unittest.skipIf(TEST_NETWORK != 'regtest', 'elementsd doesnt yet support PSBT features we need')
def test_spliceout_exceeds_channel_balance(node_factory):
"""Test splicing out more than the channel balance fails"""
l1, l2 = node_factory.line_graph(2, fundamount=1000000, wait_for_announce=True,
opts={'experimental-splicing': None})
with pytest.raises(RpcError):
l1.rpc.spliceout("*:?", "99999999") # way more than channel holds
p1 = only_one(l1.rpc.listpeerchannels(peer_id=l2.info['id'])['channels'])
assert 'inflight' not in p1
Loading