hsmd: fix HSM sent an unknown message type error #8728
+46
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8726
When we enter the wrong passphrase hsmd crashes like this with an unknown message type:
This change swaps write_all() to wire_synce_write() because write_all() is missing the wire protocol length prefix. Something to note is that we will still see a crash dump here because we are finishing with a status_failed() which produces a crash dump, this consistent with other hsm failures, we don't want to be starting up if we've been given the wrong passphrase. So the dump should look like this now:
Changelog-None